From: Andre Vehreschild <vehre@gmx.de>
To: GCC-Patches-ML <gcc-patches@gcc.gnu.org>,
GCC-Fortran-ML <fortran@gcc.gnu.org>
Cc: Tobias Burnus <tobias@codesourcery.com>,
Brad Richardson <brad@sourceryinstitute.org>,
Damian Rouson <damian@sourceryinstitute.org>
Subject: Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
Date: Wed, 23 Jun 2021 10:23:18 +0200 [thread overview]
Message-ID: <20210623102318.09d8b23f@vepi2> (raw)
In-Reply-To: <9f94b856-c988-7341-60f1-601b698262e8@codesourcery.com>
Hi all,
the fix for PR100337 was submitted as da13e4ebebb07a47d5fb50eab8893f8fe38683df.
Thanks for the review Tobias.
@Tobias: You are right, caf_single does not get much testing. But this part
(not providing a stat) is tested multiple times, because of the laziness. Nearly
none of the tests in the testsuite provides a variable for stat.
Will wait two weeks for any errors introduced by this patch before backporting
to gcc-11, ok?
Regards,
Andre
On Tue, 22 Jun 2021 10:37:27 +0200
Tobias Burnus <tobias@codesourcery.com> wrote:
> Hi Andre,
>
> On 22.06.21 09:40, Andre Vehreschild via Fortran wrote:
> > To the questions:
> > - I added a test only for -fcoarray=single because in the library case the
> > optional stat is just propagated to the library, which is already tested
> > a lot of times and which needs to handle the optional stat in any case. So
> > an error there would have been detected in one of the earlier tests. I did
> > not want to add unnecessary test overhead given that the tests already run
> > for a long time.
> Fair point.
> > - I did not add tests for the other CO_* routines, i.e. CO_MIN, CO_MAX,
> > CO_REDUCE or CO_SUM, that are also handled by this routine, because I
> > believe that showing that the fix works for CO_BROADCAST shows that the
> > others work, too. Because the four others do not have any special handling
> > in their implementation in trans_intrinsic. Or do you mean other
> > coarray-routines besides the five handled by conv_co_collective()?
> Well, that relates more to the first point – for -fcoarray=lib, it
> likely makes a difference. For -fcoarray=single not. If the former is
> skipped, it is much less relevant for the second.
> > If it is ok for you, I would apply the patch as is, or do you see a reason
> > to add more tests?
>
> OK.
>
> Although, I am not that sure that libcaf_single gets that much testing.
> On the other hand, -fcoarray=lib with -lcaf_single is also not that
> relevant in the real world, either.
>
> Tobias
>
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank
> Thürauf
--
Andre Vehreschild * Email: vehre ad gmx dot de
next prev parent reply other threads:[~2021-06-23 8:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 13:33 [Patch, " Andre Vehreschild
2021-06-04 16:05 ` [Ping, Patch, " Andre Vehreschild
2021-06-19 11:23 ` [Ping^2, " Andre Vehreschild
2021-06-21 12:30 ` Tobias Burnus
2021-06-22 7:40 ` Andre Vehreschild
2021-06-22 8:37 ` Tobias Burnus
2021-06-23 8:23 ` Andre Vehreschild [this message]
2021-06-23 9:21 ` Tobias Burnus
2022-02-14 15:50 ` [Backport gcc-11, " Andre Vehreschild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623102318.09d8b23f@vepi2 \
--to=vehre@gmx.de \
--cc=brad@sourceryinstitute.org \
--cc=damian@sourceryinstitute.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).