From: Tobias Burnus <tobias@codesourcery.com>
To: Andre Vehreschild <vehre@gmx.de>,
GCC-Patches-ML <gcc-patches@gcc.gnu.org>,
GCC-Fortran-ML <fortran@gcc.gnu.org>
Cc: Brad Richardson <brad@sourceryinstitute.org>
Subject: Re: [Ping^2, Patch, Fortran] PR100337 Should be able to pass non-present optional arguments to CO_BROADCAST
Date: Mon, 21 Jun 2021 14:30:21 +0200 [thread overview]
Message-ID: <f2c8326b-f75d-9988-ee3b-010aace3e0d8@codesourcery.com> (raw)
In-Reply-To: <20210619132332.302f1062@vepi2>
Any reason that you did not put it under
gfortran.dg/coarray/
such that it is also run with -fcoarray=lib (-lcaf_single)?
I know that the issue only exists for single, but it also makes
sense to check that libcaf_single works ....
In that sense, I wonder whether also the other CO_* should be
checked in the testsuite as they are handled differently in
libcaf_... (but identical with -fcoarray=single).
Except for those two nits, it LGTM. Thanks!
Tobias
PS: The function is used by
case GFC_ISYM_CO_BROADCAST:
case GFC_ISYM_CO_MIN:
case GFC_ISYM_CO_MAX:
case GFC_ISYM_CO_REDUCE:
case GFC_ISYM_CO_SUM:
and, with -fcoarray=single, errmsg is not touched
as stat is (unconditionally) 0 (success)..
On 19.06.21 13:23, Andre Vehreschild via Fortran wrote:
> PING!
>
> On Fri, 4 Jun 2021 18:05:18 +0200
> Andre Vehreschild <vehre@gmx.de> wrote:
>
>> Ping!
>>
>> On Fri, 21 May 2021 15:33:11 +0200
>> Andre Vehreschild <vehre@gmx.de> wrote:
>>
>>> Hi,
>>>
>>> the attached patch fixes an issue when calling CO_BROADCAST in
>>> -fcoarray=single mode, where the optional but non-present (in the calling
>>> scope) stat variable was assigned to before checking for it being not
>>> present.
>>>
>>> Regtests fine on x86-64-linux/f33. Ok for trunk?
>>>
>>> Regards,
>>> Andre
>>
>
> --
> Andre Vehreschild * Email: vehre ad gmx dot de
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 München Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Frank Thürauf
next prev parent reply other threads:[~2021-06-21 12:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 13:33 [Patch, " Andre Vehreschild
2021-06-04 16:05 ` [Ping, Patch, " Andre Vehreschild
2021-06-19 11:23 ` [Ping^2, " Andre Vehreschild
2021-06-21 12:30 ` Tobias Burnus [this message]
2021-06-22 7:40 ` Andre Vehreschild
2021-06-22 8:37 ` Tobias Burnus
2021-06-23 8:23 ` Andre Vehreschild
2021-06-23 9:21 ` Tobias Burnus
2022-02-14 15:50 ` [Backport gcc-11, " Andre Vehreschild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2c8326b-f75d-9988-ee3b-010aace3e0d8@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=brad@sourceryinstitute.org \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=vehre@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).