From: Harald Anlauf <anlauf@gmx.de>
To: fortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: error recovery simplifying PACK with invalid arguments [PR106049]
Date: Tue, 12 Jul 2022 20:23:36 +0200 [thread overview]
Message-ID: <3b9de2bf-a196-d7ee-cef3-a4afd2b18866@gmx.de> (raw)
Message-ID: <20220712182336.1ZWh-WCeXNnFO4_snmqs0ScXpb5uWqoBzAGZsYJU_T8@z> (raw)
In-Reply-To: <trinity-496cd4b0-bce1-425b-9da2-2d81efd21e01-1657053102400@3c-app-gmx-bs53>
As there were no comments, committed as r13-1650.
Am 05.07.22 um 22:31 schrieb Harald Anlauf via Fortran:
> Dear all,
>
> poor error recovery while trying to simplify intrinsics with given
> invalid arguments seems to be a recurrent theme in testcases submitted
> by Gerhard. In the present case, simplification of PACK() chokes on
> the array argument being a bad decl.
>
> The most general approach that came to my mind is to modify function
> is_constant_array_expr: when the declared shape of the array indicates
> a size greater than zero, but the constructor is missing or empty,
> then something bad may have happened, and the array cannot be
> considered constant. We thus punt on simplification of something
> that cannot be simplified. With some luck, this might prevent issues
> in similar cases elsewhere...
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>
> Thanks,
> Harald
>
next prev parent reply other threads:[~2022-07-12 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 20:31 Harald Anlauf
2022-07-12 18:23 ` Harald Anlauf [this message]
2022-07-12 18:23 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b9de2bf-a196-d7ee-cef3-a4afd2b18866@gmx.de \
--to=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).