From: Nathan Sidwell <nathan@acm.org>
To: Ben Boeckel <ben.boeckel@kitware.com>
Cc: Jason Merrill <jason@redhat.com>,
gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, gcc@gcc.gnu.org,
brad.king@kitware.com
Subject: Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies
Date: Fri, 21 Jul 2023 16:23:07 -0400 [thread overview]
Message-ID: <25ec1e77-fffd-1f39-c797-4a9ba982b22d@acm.org> (raw)
In-Reply-To: <ZLqczbCfcZ+uUVOZ@farprobe>
On 7/21/23 10:57, Ben Boeckel wrote:
> On Thu, Jul 20, 2023 at 17:00:32 -0400, Nathan Sidwell wrote:
>> On 7/19/23 20:47, Ben Boeckel wrote:
>>> But it is inhibiting distributed builds because the distributing tool
>>> would need to know:
>>>
>>> - what CMIs are actually imported (here, "read the module mapper file"
>>> (in CMake's case, this is only the modules that are needed; a single
>>> massive mapper file for an entire project would have extra entries) or
>>> "act as a proxy for the socket/program specified" for other
>>> approaches);
>>
>> This information is in the machine (& human) README section of the CMI.
>
> Ok. That leaves it up to distributing build tools to figure out at
> least.
>
>>> - read the CMIs as it sends to the remote side to gather any other CMIs
>>> that may be needed (recursively);
>>>
>>> Contrast this with the MSVC and Clang (17+) mechanism where the command
>>> line contains everything that is needed and a single bolus can be sent.
>>
>> um, the build system needs to create that command line? Where does the build
>> system get that information? IIUC it'll need to read some file(s) to do that.
>
> It's chained through the P1689 information in the collator as needed. No
> extra files need to be read (at least with CMake's approach); certainly
> not CMI files.
It occurs to me that the model I am envisioning is similar to CMake's object
libraries. Object libraries are a convenient name for a bunch of object files.
IIUC they're linked by naming the individual object files (or I think the could
be implemented as a static lib linked with --whole-archive path/to/libfoo.a
-no-whole-archive. But for this conversation consider them a bunch of separate
object files with a convenient group name.
Consider also that object libraries could themselves contain object libraries (I
don't know of they can, but it seems like a useful concept). Then one could
create an object library from a collection of object files and object libraries
(recursively). CMake would handle the transitive gtaph.
Now, allow an object library to itself have some kind of tangible, on-disk
representation. *BUT* not like a static library -- it doesn't include the
object files.
Now that immediately maps onto modules.
CMI: Object library
Direct imports: Direct object libraries of an object library
This is why I don't understand the need explicitly indicate the indirect imports
of a CMI. CMake knows them, because it knows the graph.
>
>>> And relocatable is probably fine. How does it interact with reproducible
>>> builds? Or are GCC CMIs not really something anyone should consider for
>>> installation (even as a "here, maybe this can help consumers"
>>> mechanism)?
>>
>> Module CMIs should be considered a cacheable artifact. They are neither object
>> files nor source files.
>
> Sure, cachable sounds fine. What about the installation?
>
> --Ben
--
Nathan Sidwell
next prev parent reply other threads:[~2023-07-21 20:23 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 21:06 [PATCH v5 0/5] P1689R5 support Ben Boeckel
2023-01-25 21:06 ` [PATCH v5 1/5] libcpp: reject codepoints above 0x10FFFF Ben Boeckel
2023-02-13 15:53 ` Jason Merrill
2023-05-12 14:26 ` Ben Boeckel
2023-01-25 21:06 ` [PATCH v5 2/5] libcpp: add a function to determine UTF-8 validity of a C string Ben Boeckel
2023-10-23 15:16 ` David Malcolm
2023-10-23 15:24 ` Jason Merrill
2023-10-23 15:28 ` David Malcolm
2023-01-25 21:06 ` [PATCH v5 3/5] p1689r5: initial support Ben Boeckel
2023-02-14 21:50 ` Jason Merrill
2023-05-12 14:24 ` Ben Boeckel
2023-06-19 21:33 ` Jason Merrill
2023-06-20 16:51 ` Ben Boeckel
2023-06-20 19:46 ` Ben Boeckel
2023-06-23 18:31 ` Jason Merrill
2023-06-25 17:08 ` Ben Boeckel
2023-01-25 21:06 ` [PATCH v5 4/5] c++modules: report imported CMI files as dependencies Ben Boeckel
2023-02-13 18:33 ` Jason Merrill
2023-05-12 14:26 ` Ben Boeckel
2023-06-22 21:21 ` Jason Merrill
2023-06-23 2:45 ` Ben Boeckel
2023-06-23 12:12 ` Nathan Sidwell
2023-06-25 16:36 ` Ben Boeckel
2023-07-18 20:52 ` Jason Merrill
2023-07-18 21:12 ` Nathan Sidwell
2023-07-19 0:01 ` Ben Boeckel
2023-07-19 21:11 ` Nathan Sidwell
2023-07-20 0:47 ` Ben Boeckel
2023-07-20 21:00 ` Nathan Sidwell
2023-07-21 14:57 ` Ben Boeckel
2023-07-21 20:23 ` Nathan Sidwell [this message]
2023-07-24 0:26 ` Ben Boeckel
2023-07-28 1:13 ` Jason Merrill
2023-07-29 14:25 ` Ben Boeckel
2023-01-25 21:06 ` [PATCH v5 5/5] c++modules: report module mapper files as a dependency Ben Boeckel
2023-06-23 14:44 ` Jason Merrill
2023-06-25 16:42 ` Ben Boeckel
2023-02-02 14:04 ` [PATCH v5 0/5] P1689R5 support Ben Boeckel
2023-02-02 20:24 ` Harald Anlauf
2023-02-03 4:00 ` Ben Boeckel
2023-02-03 4:07 ` Andrew Pinski
2023-02-03 8:58 ` Jonathan Wakely
2023-02-03 9:10 ` Jonathan Wakely
2023-02-03 14:52 ` Ben Boeckel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ec1e77-fffd-1f39-c797-4a9ba982b22d@acm.org \
--to=nathan@acm.org \
--cc=ben.boeckel@kitware.com \
--cc=brad.king@kitware.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).