From: Ben Boeckel <ben.boeckel@kitware.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org, nathan@acm.org, fortran@gcc.gnu.org,
gcc@gcc.gnu.org, brad.king@kitware.com
Subject: Re: [PATCH v5 1/5] libcpp: reject codepoints above 0x10FFFF
Date: Fri, 12 May 2023 10:26:08 -0400 [thread overview]
Message-ID: <ZF5MgBG7rf1UJU+6@megas.dev.benboeckel.internal> (raw)
In-Reply-To: <6427dfd9-9ccd-c313-9251-75b9de8bc0af@redhat.com>
On Mon, Feb 13, 2023 at 10:53:17 -0500, Jason Merrill wrote:
> On 1/25/23 13:06, Ben Boeckel wrote:
> > Unicode does not support such values because they are unrepresentable in
> > UTF-16.
> >
> > libcpp/
> >
> > * charset.cc: Reject encodings of codepoints above 0x10FFFF.
> > UTF-16 does not support such codepoints and therefore all
> > Unicode rejects such values.
>
> It seems that this causes a bunch of testsuite failures from tests that
> expect this limit to be checked elsewhere with a different diagnostic,
> so I think the easiest thing is to fold this into _cpp_valid_utf8_str
> instead, i.e.:
Since then, `cpp_valid_utf8_p` has appeared and takes care of the
over-long encodings. The new patchset just checks for codepoints beyond
0x10FFFF and rejects them in this function (and the test suite matches
`master` results for me then).
--Ben
next prev parent reply other threads:[~2023-05-12 14:26 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 21:06 [PATCH v5 0/5] P1689R5 support Ben Boeckel
2023-01-25 21:06 ` [PATCH v5 1/5] libcpp: reject codepoints above 0x10FFFF Ben Boeckel
2023-02-13 15:53 ` Jason Merrill
2023-05-12 14:26 ` Ben Boeckel [this message]
2023-01-25 21:06 ` [PATCH v5 2/5] libcpp: add a function to determine UTF-8 validity of a C string Ben Boeckel
2023-10-23 15:16 ` David Malcolm
2023-10-23 15:24 ` Jason Merrill
2023-10-23 15:28 ` David Malcolm
2023-01-25 21:06 ` [PATCH v5 3/5] p1689r5: initial support Ben Boeckel
2023-02-14 21:50 ` Jason Merrill
2023-05-12 14:24 ` Ben Boeckel
2023-06-19 21:33 ` Jason Merrill
2023-06-20 16:51 ` Ben Boeckel
2023-06-20 19:46 ` Ben Boeckel
2023-06-23 18:31 ` Jason Merrill
2023-06-25 17:08 ` Ben Boeckel
2023-01-25 21:06 ` [PATCH v5 4/5] c++modules: report imported CMI files as dependencies Ben Boeckel
2023-02-13 18:33 ` Jason Merrill
2023-05-12 14:26 ` Ben Boeckel
2023-06-22 21:21 ` Jason Merrill
2023-06-23 2:45 ` Ben Boeckel
2023-06-23 12:12 ` Nathan Sidwell
2023-06-25 16:36 ` Ben Boeckel
2023-07-18 20:52 ` Jason Merrill
2023-07-18 21:12 ` Nathan Sidwell
2023-07-19 0:01 ` Ben Boeckel
2023-07-19 21:11 ` Nathan Sidwell
2023-07-20 0:47 ` Ben Boeckel
2023-07-20 21:00 ` Nathan Sidwell
2023-07-21 14:57 ` Ben Boeckel
2023-07-21 20:23 ` Nathan Sidwell
2023-07-24 0:26 ` Ben Boeckel
2023-07-28 1:13 ` Jason Merrill
2023-07-29 14:25 ` Ben Boeckel
2023-01-25 21:06 ` [PATCH v5 5/5] c++modules: report module mapper files as a dependency Ben Boeckel
2023-06-23 14:44 ` Jason Merrill
2023-06-25 16:42 ` Ben Boeckel
2023-02-02 14:04 ` [PATCH v5 0/5] P1689R5 support Ben Boeckel
2023-02-02 20:24 ` Harald Anlauf
2023-02-03 4:00 ` Ben Boeckel
2023-02-03 4:07 ` Andrew Pinski
2023-02-03 8:58 ` Jonathan Wakely
2023-02-03 9:10 ` Jonathan Wakely
2023-02-03 14:52 ` Ben Boeckel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF5MgBG7rf1UJU+6@megas.dev.benboeckel.internal \
--to=ben.boeckel@kitware.com \
--cc=brad.king@kitware.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gcc@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=nathan@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).