public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Mikael Morin <morin-mikael@orange.fr>,
	fortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/105501 - check for non-optional spaces between adjacent keywords
Date: Mon, 9 May 2022 21:34:00 +0200	[thread overview]
Message-ID: <37207063-62ba-27b4-8c10-f530c2cd1273@gmx.de> (raw)
In-Reply-To: <c874ff05-b698-fa09-bc18-82a31e99603c@orange.fr>

Hi Mikael,

Am 09.05.22 um 20:24 schrieb Mikael Morin:
> The fix itself looks good.  Regarding the test, I don’t understand the
> problem.  Can’t there be multiple subroutines, each having one (or more)
> problematic statement(s)?

that's why I tried but failed.  Example:

subroutine a
   errorstop
end
subroutine b
   errorstop
end

This now gives just one (the first) error, after which it bails out:

xxx.f90:2:3:

     2 |   errorstop
       |   1
Error: Unclassifiable statement at (1)

That is the reason I mentioned it.

I'll commit the patch as-is.

Thanks for the review!
Harald

  reply	other threads:[~2022-05-09 19:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-08 20:17 Harald Anlauf
2022-05-09 18:24 ` Mikael Morin
2022-05-09 19:34   ` Harald Anlauf [this message]
2022-05-10 11:54     ` Mikael Morin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37207063-62ba-27b4-8c10-f530c2cd1273@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=morin-mikael@orange.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).