From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/105501 - check for non-optional spaces between adjacent keywords
Date: Mon, 9 May 2022 20:24:18 +0200 [thread overview]
Message-ID: <c874ff05-b698-fa09-bc18-82a31e99603c@orange.fr> (raw)
In-Reply-To: <trinity-927b057e-4950-4ce5-bf8f-4ec039fab04b-1652041031263@3c-app-gmx-bs41>
Le 08/05/2022 à 22:17, Harald Anlauf via Fortran a écrit :
> Dear all,
>
> the PR correctly notes that a space between keywords 'TYPE' and 'IS' is
> required in free-form, but we currently accept 'TYPEIS'. We shouldn't.
> The combinations with non-optional blanks are listed in the standard;
> in F2018 this is table 6.2.
>
> While at it, I saw a couple of other keyword combinations in the matcher
> and fixed these too. I cross-checked my findings with Intel, Crayftn,
> and NAG (as far as possible).
>
> Regarding the testcase: I do not know how to write a (single!) testcase
> that is able to check multiple of those fixes. I also do not think that
> it makes sense to provide a testcase for each single fixed pattern.
> Therefore a provided a single, minimal testcase based on the report.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline (i.e. 13-master)?
>
The fix itself looks good. Regarding the test, I don’t understand the
problem. Can’t there be multiple subroutines, each having one (or more)
problematic statement(s)?
next prev parent reply other threads:[~2022-05-09 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 20:17 Harald Anlauf
2022-05-09 18:24 ` Mikael Morin [this message]
2022-05-09 19:34 ` Harald Anlauf
2022-05-10 11:54 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c874ff05-b698-fa09-bc18-82a31e99603c@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).