From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: error recovery simplifying UNPACK for insufficient FIELD [PR107922]
Date: Sun, 4 Dec 2022 14:11:03 +0100 [thread overview]
Message-ID: <428cdc11-84c7-3837-e96f-9ec00c640643@orange.fr> (raw)
In-Reply-To: <trinity-36a140f9-17a0-4d3d-8a78-f2ae946960cb-1669926330700@3c-app-gmx-bs60>
Le 01/12/2022 à 21:25, Harald Anlauf via Fortran a écrit :
> Dear all,
>
> we did not properly handle the case of insufficient array-valued
> FIELD when trying to simplify UNPACK and could run into a NULL
> pointer dereference. The fix is obvious.
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>
The change looks good, but please add braces around the new if-else
structure.
OK with that change.
Thanks.
next prev parent reply other threads:[~2022-12-04 13:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 20:25 Harald Anlauf
2022-12-04 13:11 ` Mikael Morin [this message]
2022-12-04 20:04 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428cdc11-84c7-3837-e96f-9ec00c640643@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).