public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Mikael Morin <morin-mikael@orange.fr>,
	fortran <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: error recovery simplifying UNPACK for insufficient FIELD [PR107922]
Date: Sun, 4 Dec 2022 21:04:58 +0100	[thread overview]
Message-ID: <7968b07a-6453-d592-c5a0-bb28699dab01@gmx.de> (raw)
In-Reply-To: <428cdc11-84c7-3837-e96f-9ec00c640643@orange.fr>

Hi Mikael,

Am 04.12.22 um 14:11 schrieb Mikael Morin:
> Le 01/12/2022 à 21:25, Harald Anlauf via Fortran a écrit :
>> Dear all,
>>
>> we did not properly handle the case of insufficient array-valued
>> FIELD when trying to simplify UNPACK and could run into a NULL
>> pointer dereference.  The fix is obvious.
>>
>> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
>>
> The change looks good, but please add braces around the new if-else
> structure.
> OK with that change.

thanks for the hint.  It indeed looks more readable with this small change.

Pushed: r13-4486-g24b9337d1f1b5197b6498dceb9074319be003449

> Thanks.
>

Thanks,
Harald


      reply	other threads:[~2022-12-04 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 20:25 Harald Anlauf
2022-12-04 13:11 ` Mikael Morin
2022-12-04 20:04   ` Harald Anlauf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7968b07a-6453-d592-c5a0-bb28699dab01@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=morin-mikael@orange.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).