Re: [gomp4] add support for fortran allocate support with declare create

[Cesar Philippidis <cesar@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

On 04/06/2017 02:05 AM, Thomas Schwinge wrote:

>> --- /dev/null
>> +++ b/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90
>> @@ -0,0 +1,25 @@
>> +! Verify that OpenACC declared allocatable arrays have implicit
>> +! OpenACC enter and exit pragmas at the time of allocation and
>> +! deallocation.
>> +
>> +! { dg-additional-options "-fdump-tree-original" }
>> +[...]
>> +! { dg-final { scan-tree-dump-times "pragma acc enter data map.declare_allocate" 1 "gimple" } }
>> +! { dg-final { scan-tree-dump-times "pragma acc exit data map.declare_deallocate" 1 "gimple" } }
> 
>     UNRESOLVED: gfortran.dg/goacc/declare-allocatable-1.f90   -O   scan-tree-dump-times gimple "pragma acc enter data map.declare_allocate" 1
>     UNRESOLVED: gfortran.dg/goacc/declare-allocatable-1.f90   -O   scan-tree-dump-times gimple "pragma acc exit data map.declare_deallocate" 1
>     PASS: gfortran.dg/goacc/declare-allocatable-1.f90   -O  (test for excess errors)
> 
> "original" vs. "gimple" -- which one should it be?

I'm bad at noticing new unresolved test cases.

It could be either, but I changed it to original to ensure that the
fortran FE inserts those acc enter/exit data directives appropriately.

This patch has been committed to gomp-4_0-branch.

Cesar

[-- Attachment #2: gomp4-declare-test.diff --]
[-- Type: text/x-patch, Size: 896 bytes --]

2017-04-06  Cesar Philippidis  <cesar@codesourcery.com>

	gcc/testsuite/
	* gfortran.dg/goacc/declare-allocatable-1.f90: Correct test.

diff --git a/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90 b/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90
index 9195055..b6bb6b3 100644
--- a/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90
+++ b/gcc/testsuite/gfortran.dg/goacc/declare-allocatable-1.f90
@@ -21,5 +21,5 @@ program allocate
   deallocate (a)
 end program allocate
 
-! { dg-final { scan-tree-dump-times "pragma acc enter data map.declare_allocate" 1 "gimple" } }
-! { dg-final { scan-tree-dump-times "pragma acc exit data map.declare_deallocate" 1 "gimple" } }
+! { dg-final { scan-tree-dump-times "pragma acc enter data map.declare_allocate" 1 "original" } }
+! { dg-final { scan-tree-dump-times "pragma acc exit data map.declare_deallocate" 1 "original" } }