Re: Add 'libgomp.oacc-fortran/declare-allocatable-1.f90' (was: [gomp4] add support for fortran allocate support with declare create)

[Thomas Schwinge <thomas@codesourcery.com>]

Hi!

Let me add back CC: <fortran@gcc.gnu.org>, so that others may comment,
too.

On 2022-11-03T01:37:10+0100, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
> On 2 November 2022 21:04:56 CET, Thomas Schwinge <thomas@codesourcery.com> wrote:
>>> --- /dev/null
>>> +++ b/libgomp/testsuite/libgomp.oacc-fortran/declare-allocatable-1.f90
>>> @@ -0,0 +1,211 @@
>>> +! Test declare create with allocatable arrays.
>>
>>... is useful in a different (though related) context that I'm currently
>>working on.  Having applied the following changes:
>>
>>  - Replace 'call abort' by 'error stop' (in spirit of earlier PR84381
>>    changes).
>
> Please remind me why you don't stop N
> but error stop?

  - Don't have to re-number if changing test case later on.
  - Prints a backtrace (where supported).

> Re: https://gcc.gnu.org/legacy-ml/fortran/2018-09/msg00173.html
>
> You'd obviously tweak
> sub(/call\s\s*abort/, "stop " i)
> with error\s\s*stop
>
> Or is your output so br^W lacking that you cannot write but just return? But then i think that error stop writes, too, so that cannot be the case, can it?

Right.


Grüße
 Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955