Re: [PATCH, v3] Fortran: improve array component description in runtime error message [PR30802]

[Mikael Morin <morin-mikael@orange.fr>]

Le 20/03/2024 à 21:24, Harald Anlauf a écrit :
> Hi Mikael, all,
> 
> here's now the third version of the patch that implements the following
> scheme:
> 
> On 3/15/24 20:29, Mikael Morin wrote:
>> Le 15/03/2024 à 18:26, Harald Anlauf a écrit :
>>> OK, that sounds interesting.  To clarify the options:
>>>
>>> - for ordinary array x it would stay 'x'
>>>
>>> - when z is a DT scalar, and z%x is the array in question, use 'z%x'
>>>    (here z...%x would look strange to me)
>>>
>> Yes, the ellipsis would look strange to me as well.
>>
>>> - when z is a DT array, and x some component further down, 'z...%x'
>>>
>> This case also applies when z is a DT scalar and x is more than one
>> level deep.
>>
>>> I would rather not make the error message text vary too much to avoid
>>> to run into issues with translation.  Would it be fine with you to have
>>>
>>> ... dimension 1 of array 'z...%x' above array bound ...
>>>
>>> only?
>>>
>> OK, let's drop "component".
>>
>>> Anything else?
>>>
>> No, I think you covered everything.
> 
> I've created a new helper function that centralizes the generation of
> the abbreviated name of the array (component) and use it to simplify
> related code in multiple places.  If we change our mind how a bounds
> violation error message should look like, it will be easier to adjust
> in the future.
> 
> Is this OK for 14-mainline?
> 
Yes, thanks.

> Thanks,
> Harald
> 
>