Re: [Patch] Fortran: Fix gfc_conv_gfc_desc_to_cfi_desc with NULL [PR104126]

[Tobias Burnus <tobias@codesourcery.com>]

Hi Harald,

On 08.03.22 22:44, Harald Anlauf wrote:
> Am 07.03.22 um 15:16 schrieb Tobias Burnus:
>> Pre-remark: Related NULL, there some accepts-invalid issues, not
>> addressed in this
>> patch. See https://gcc.gnu.org/PR104819
>>
>> This patch fixes an ICE (12 regression) with NULL() that has no MOLD
>> argument.
> the patch does fix the ICE.  But given your short pre-remark:
> are you saying that the testcase is invalid, and with the patch
> we silently accept it now?

Sorry for being confusing. I also believe the testcase of the just
committed patch is valid Fortran.

However, when fixing this PR, I was looking at the spec – and saw that
GCC accepts invalid code using NULL(), which is not diagnosed. Those
issues are orthogonal to this patch, except that the accepts-invalid
issues also are about NULL().

Thanks for the review!

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955