public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [Patch] Fortran: Fix gfc_conv_gfc_desc_to_cfi_desc with NULL [PR104126]
Date: Tue, 8 Mar 2022 22:44:11 +0100	[thread overview]
Message-ID: <e910d4d8-f348-045f-4829-0ecaa286c0a0@gmx.de> (raw)
Message-ID: <20220308214411.aoDHxi_ESZLp34XEW1INSpv1KkdJ9ThCuMe726pkRVA@z> (raw)
In-Reply-To: <5535ea6a-80d1-c674-fa5b-a28ec26c2ce0@codesourcery.com>

Hi Tobias,

Am 07.03.22 um 15:16 schrieb Tobias Burnus:
> Pre-remark: Related NULL, there some accepts-invalid issues, not 
> addressed in this
> patch. See https://gcc.gnu.org/PR104819
> 
> This patch fixes an ICE (12 regression) with NULL() that has no MOLD 
> argument.

the patch does fix the ICE.  But given your short pre-remark:
are you saying that the testcase is invalid, and with the patch
we silently accept it now?

(The testcase compiles with Intel, but triggers a funny bug in
crayftn, which made me read 16.9.144 to learn more about the
tricks of NULL.  But I tend to think this case is valid.)

> OK for mainline?

LGTM.

Thanks for the patch!

Harald

> Tobias
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 
> 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: 
> Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; 
> Registergericht München, HRB 106955



  reply	other threads:[~2022-03-08 21:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 14:16 Tobias Burnus
2022-03-08 21:44 ` Harald Anlauf [this message]
2022-03-08 21:44   ` Harald Anlauf
2022-03-08 23:34   ` Tobias Burnus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e910d4d8-f348-045f-4829-0ecaa286c0a0@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).