From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: ordering of hidden procedure arguments [PR107441]
Date: Mon, 31 Oct 2022 10:57:58 +0100 [thread overview]
Message-ID: <85a5951a-7ea4-57b3-895a-ff7dbf1ef92e@orange.fr> (raw)
In-Reply-To: <327319ac-4ef9-1e48-e993-57113d802d3b@orange.fr>
Le 30/10/2022 à 22:25, Mikael Morin a écrit :
> Le 30/10/2022 à 20:23, Mikael Morin a écrit :
>> Another probable issue is your change to create_function_arglist
>> changes arglist/hidden_arglist without also changing
>> typelist/hidden_typelist accordingly. I think a change to
>> gfc_get_function_type is also necessary: as the function decl is
>> changed, the decl type need to be changed as well.
>>
>> I will see whether I can manage to exhibit testcases for these issues.
>>
> Here is a test for the type vs decl mismatch.
>
> ! { dg-do run }
> !
> ! PR fortran/107441
> ! Check that procedure types and procedure decls match when the procedure
> ! has both chaacter-typed and optional value args.
>
> program p
> interface
> subroutine i(c, o)
> character(*) :: c
> integer, optional, value :: o
> end subroutine i
> end interface
> procedure(i), pointer :: pp
A pointer initialization is missing here:
pp => s
> call pp("abcd")
> contains
> subroutine s(c, o)
> character(*) :: c
> integer, optional, value :: o
> if (present(o)) stop 1
> if (len(c) /= 4) stop 2
> if (c /= "abcd") stop 3
> end subroutine s
> end program p
>
With the additional initialization, the test passes, so it's not very
useful. The type mismatch is visible in the dump though, so maybe a
dump match can be used.
next prev parent reply other threads:[~2022-10-31 9:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:12 Harald Anlauf
2022-10-30 19:23 ` Mikael Morin
2022-10-30 20:32 ` Mikael Morin
2022-10-30 21:25 ` Mikael Morin
2022-10-31 9:57 ` Mikael Morin [this message]
2022-10-31 20:29 ` [PATCH, v2] " Harald Anlauf
2022-10-31 20:29 ` Harald Anlauf
2022-11-02 17:20 ` Mikael Morin
2022-11-02 21:19 ` Harald Anlauf
2022-11-02 21:19 ` Harald Anlauf
2022-11-03 10:06 ` Mikael Morin
2022-11-03 22:03 ` Harald Anlauf
2022-11-03 22:03 ` Harald Anlauf
2022-11-04 9:53 ` Mikael Morin
2022-11-07 21:45 ` [PATCH, v3] " Harald Anlauf
2022-11-07 21:45 ` Harald Anlauf
2022-11-08 10:32 ` Mikael Morin
2022-11-08 20:31 ` Harald Anlauf
2022-11-08 20:31 ` Harald Anlauf
2022-11-08 21:39 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85a5951a-7ea4-57b3-895a-ff7dbf1ef92e@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).