From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: ordering of hidden procedure arguments [PR107441]
Date: Sun, 30 Oct 2022 21:32:17 +0100 [thread overview]
Message-ID: <c9736063-f3c6-bf25-e2fd-a679c3fb5bd3@orange.fr> (raw)
In-Reply-To: <7d8ddf07-e66d-2678-de99-0e575c70ea17@orange.fr>
Le 30/10/2022 à 20:23, Mikael Morin a écrit :
>
> I think some discrepancy remains, as gfc_conv_procedure_call accumulates
> coarray stuff into the stringargs, while your change accumulates the
> associated parameter decls separately into hidden_arglist. It's not
> completely clear to me whether it is really problematic (string length
> and coarray metadata are both integers anyway), but I suspect it is.
> > I will see whether I can manage to exhibit testcases for these issues.
>
Here is a -fcoarray=lib example. It can be placed in gfortran/coarray.
! { dg-do run }
!
! PR fortran/107441
! Check that with -fcoarray=lib, coarray metadata arguments are passed
! in the right order to procedures.
program p
integer :: ci[*]
ci = 17
call s(1, ci, "abcd")
contains
subroutine s(ra, ca, c)
integer :: ra, ca[*]
character(*) :: c
ca[1] = 13
if (ra /= 1) stop 1
if (this_image() == 1) then
if (ca /= 13) stop 2
else
if (ca /= 17) stop 3
end if
if (len(c) /= 4) stop 4
if (c /= "abcd") stop 5
end subroutine s
end program p
next prev parent reply other threads:[~2022-10-30 20:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:12 Harald Anlauf
2022-10-30 19:23 ` Mikael Morin
2022-10-30 20:32 ` Mikael Morin [this message]
2022-10-30 21:25 ` Mikael Morin
2022-10-31 9:57 ` Mikael Morin
2022-10-31 20:29 ` [PATCH, v2] " Harald Anlauf
2022-10-31 20:29 ` Harald Anlauf
2022-11-02 17:20 ` Mikael Morin
2022-11-02 21:19 ` Harald Anlauf
2022-11-02 21:19 ` Harald Anlauf
2022-11-03 10:06 ` Mikael Morin
2022-11-03 22:03 ` Harald Anlauf
2022-11-03 22:03 ` Harald Anlauf
2022-11-04 9:53 ` Mikael Morin
2022-11-07 21:45 ` [PATCH, v3] " Harald Anlauf
2022-11-07 21:45 ` Harald Anlauf
2022-11-08 10:32 ` Mikael Morin
2022-11-08 20:31 ` Harald Anlauf
2022-11-08 20:31 ` Harald Anlauf
2022-11-08 21:39 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9736063-f3c6-bf25-e2fd-a679c3fb5bd3@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).