From: Mikael Morin <morin-mikael@orange.fr>
To: Harald Anlauf <anlauf@gmx.de>, fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, v2] Fortran: ordering of hidden procedure arguments [PR107441]
Date: Thu, 3 Nov 2022 11:06:41 +0100 [thread overview]
Message-ID: <91afe6ef-e5f4-d3d8-ad15-3271fd4e61cd@orange.fr> (raw)
In-Reply-To: <8725411a-979b-dd53-d1fe-5b041482a8eb@gmx.de>
Le 02/11/2022 à 22:19, Harald Anlauf via Fortran a écrit :
> Am 02.11.22 um 18:20 schrieb Mikael Morin:
>> Unfortunately no, the coarray case works, but the other problem remains.
>> The type problem is not visible in the definition of S, it is in the
>> declaration of S's prototype in P.
>>
>> S is defined as:
>>
>> void s (character(kind=1)[1:_c] & restrict c, integer(kind=4) o,
>> logical(kind=1) _o, integer(kind=8) _c)
>> {
>> ...
>> }
>>
>> but P has:
>>
>> void p ()
>> {
>> static void s (character(kind=1)[1:] & restrict, integer(kind=4),
>> integer(kind=8), logical(kind=1));
>> void (*<T63a>) (character(kind=1)[1:] & restrict, integer(kind=4),
>> integer(kind=8), logical(kind=1)) pp;
>>
>> pp = s;
>> ...
>> }
>
> Right, now I see it too. Simplified case:
>
> program p
> call s ("abcd")
> contains
> subroutine s(c, o)
> character(*) :: c
> integer, optional, value :: o
> end subroutine s
> end
>
> I do see what needs to be done in gfc_get_function_type, which seems
> in fact very simple. But I get really lost in create_function_arglist
> when trying to get the typelist right.
>
> One thing is I really don't understand how the (hidden_)typelist is
> managed here. How does that macro TREE_CHAIN work? Can we somehow
> chain two typelists the same way we chain arguments?
>
TREE_CHAIN is just a linked list "next" pointer like there is in the
fortran frontend a "next" pointer in gfc_ref or gfc_actual_arglist
structures.
Yes, we can chain typelists; the implementation of chainon in tree.cc is
just TREE_CHAIN appending under the hood.
> (Failing that, I tried to split the loop over the dummy arguments in
> create_function_arglist into two passes, one for the optional+value
> variant, and one for the rest. It turned out to be a bad idea...)
>
Not necessarily a bad idea, but one has to be careful to keep linked
lists synchronized with argument walking.
The most simple, I think, is to move the hidden_typelist advancement for
optional, value presence arguments from the main loop to a preliminary loop.
I hope it helps.
next prev parent reply other threads:[~2022-11-03 10:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 20:12 [PATCH] " Harald Anlauf
2022-10-30 19:23 ` Mikael Morin
2022-10-30 20:32 ` Mikael Morin
2022-10-30 21:25 ` Mikael Morin
2022-10-31 9:57 ` Mikael Morin
2022-10-31 20:29 ` [PATCH, v2] " Harald Anlauf
2022-10-31 20:29 ` Harald Anlauf
2022-11-02 17:20 ` Mikael Morin
2022-11-02 21:19 ` Harald Anlauf
2022-11-02 21:19 ` Harald Anlauf
2022-11-03 10:06 ` Mikael Morin [this message]
2022-11-03 22:03 ` Harald Anlauf
2022-11-03 22:03 ` Harald Anlauf
2022-11-04 9:53 ` Mikael Morin
2022-11-07 21:45 ` [PATCH, v3] " Harald Anlauf
2022-11-07 21:45 ` Harald Anlauf
2022-11-08 10:32 ` Mikael Morin
2022-11-08 20:31 ` Harald Anlauf
2022-11-08 20:31 ` Harald Anlauf
2022-11-08 21:39 ` Mikael Morin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91afe6ef-e5f4-d3d8-ad15-3271fd4e61cd@orange.fr \
--to=morin-mikael@orange.fr \
--cc=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).