public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: Sandra Loosemore <sandra@codesourcery.com>
To: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: Add location info to OpenMP tree nodes
Date: Mon, 4 Apr 2022 22:12:33 -0600	[thread overview]
Message-ID: <8651a26f-7b51-a57c-d4a3-8aa5b2ddebb2@codesourcery.com> (raw)
In-Reply-To: <24bde0e8-8da4-4d4f-30fd-9a9b5830b944@codesourcery.com>

On 3/25/22 20:03, Sandra Loosemore wrote:
> I've got another patch forthcoming (stage 1 material) that adds some new 
> diagnostics for non-rectangular loops during gimplification of OMP 
> nodes.  When I was working on that, I discovered that the Fortran front 
> end wasn't attaching location information to the tree nodes 
> corresponding to the various OMP directives, so the new errors weren't 
> coming out with location info either.  I went through trans-openmp.cc 
> and fixed all the places where make_node was being called to explicitly 
> set the location.
> 
> I don't have a test case specifically for this change, but my test cases 
> for the new diagnostics in the non-rectangular loops patch do exercise 
> it.  Is this OK for trunk now, or for stage 1 when we get there?

Ping!  Even a quick review and "this isn't suitable for GCC 12" answer 
would be helpful.

https://gcc.gnu.org/pipermail/fortran/2022-March/057706.html

The definitely-stage-1 patch that exercises this is here:

https://gcc.gnu.org/pipermail/fortran/2022-March/057707.html

-Sandra

  parent reply	other threads:[~2022-04-05  4:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26  2:03 Sandra Loosemore
2022-03-26  7:04 ` Jakub Jelinek
2022-04-05  4:12 ` Sandra Loosemore [this message]
2022-04-05  6:27   ` Richard Biener

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8651a26f-7b51-a57c-d4a3-8aa5b2ddebb2@codesourcery.com \
    --to=sandra@codesourcery.com \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).