From: Jakub Jelinek <jakub@redhat.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: "fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: Add location info to OpenMP tree nodes
Date: Sat, 26 Mar 2022 08:04:05 +0100 [thread overview]
Message-ID: <Yj665F4QnPEGhchG@tucnak> (raw)
In-Reply-To: <24bde0e8-8da4-4d4f-30fd-9a9b5830b944@codesourcery.com>
On Fri, Mar 25, 2022 at 08:03:09PM -0600, Sandra Loosemore wrote:
> I've got another patch forthcoming (stage 1 material) that adds some new
> diagnostics for non-rectangular loops during gimplification of OMP nodes.
> When I was working on that, I discovered that the Fortran front end wasn't
> attaching location information to the tree nodes corresponding to the
> various OMP directives, so the new errors weren't coming out with location
> info either. I went through trans-openmp.cc and fixed all the places where
> make_node was being called to explicitly set the location.
>
> I don't have a test case specifically for this change, but my test cases for
> the new diagnostics in the non-rectangular loops patch do exercise it. Is
> this OK for trunk now, or for stage 1 when we get there?
Ok for GCC 13.
> commit 4c745003d0b39d0e92032b62421df4920753783a
> Author: Sandra Loosemore <sandra@codesourcery.com>
> Date: Thu Mar 24 21:02:34 2022 -0700
>
> Fortran: Add location info to OpenMP tree nodes
>
> gcc/fortran/
> * trans-openmp.cc (gfc_trans_omp_critical): Set location on OMP
> tree node.
> (gfc_trans_omp_do): Likewise.
> (gfc_trans_omp_masked): Likewise.
> (gfc_trans_omp_do_simd): Likewise.
> (gfc_trans_omp_scope): Likewise.
> (gfc_trans_omp_taskgroup): Likewise.
> (gfc_trans_omp_taskwait): Likewise.
> (gfc_trans_omp_distribute): Likewise.
> (gfc_trans_omp_taskloop): Likewise.
> (gfc_trans_omp_master_masked_taskloop): Likewise.
Jakub
next prev parent reply other threads:[~2022-04-05 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 2:03 Sandra Loosemore
2022-03-26 7:04 ` Jakub Jelinek [this message]
2022-04-05 4:12 ` Sandra Loosemore
2022-04-05 6:27 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yj665F4QnPEGhchG@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).