From: Harald Anlauf <anlauf@gmx.de>
To: Tobias Burnus <tobias@codesourcery.com>,
fortran <fortran@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR fortran/50549 - should detect different type parameters in structure constructors
Date: Tue, 29 Mar 2022 20:48:42 +0200 [thread overview]
Message-ID: <886bfd00-2ffb-8568-0920-ee48434c92ef@gmx.de> (raw)
In-Reply-To: <89773980-593c-727a-28c9-d3304cd1aa78@codesourcery.com>
Hi Tobias,
Am 29.03.22 um 09:14 schrieb Tobias Burnus:
> Hi Harald,
>
> On 28.03.22 22:03, Harald Anlauf via Fortran wrote:
>> All current cases of printing a HOST_WIDE_INT in gcc/fortran/ use
>> 'sprintf', and I did not find any other use of %wd/%wu. So the
>> mentioned implementation is not really stressed yet... ;-)
>
> That's all your fault ;-)
true; I'm pleading guilty for that one.
> (Your commit
> https://gcc.gnu.org/r12-3273-ge4cb3bb9ac11b4126ffa718287dd509a4b10a658
> did remove the only user.)
I've now made good for it. ;-)
> That's only a warning. Have you tried whether it works at runtime?
> My bet is that it does!
Yes, it did work, it was just the warning alerting me ...
> Question: Do you build with --disable-bootstrap ? Or do you do a proper
> bootstrap?
... because I did build with --disable-bootstrap to save on time for
building the compiler on my local machine, and the system's default
gcc is older.
> Can you check & try again? I don't mind getting a format warning with
> GCC < GCC 12. But with GCC 12 compiled (either installed compiler or
> when bootstrapping) it should compile without errors.
>
> If you can confirm my suspicion, the patch LGTM.
I've just pushed that version as
https://gcc.gnu.org/g:0712f356374c2cf26015cccfa3141537e42cbb12
Sorry for the noise, and thanks for the review!
Harald
> Tobias
WARNING: multiple messages have this Message-ID
From: Harald Anlauf <anlauf@gmx.de>
To: fortran@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] PR fortran/50549 - should detect different type parameters in structure constructors
Date: Tue, 29 Mar 2022 20:48:42 +0200 [thread overview]
Message-ID: <886bfd00-2ffb-8568-0920-ee48434c92ef@gmx.de> (raw)
Message-ID: <20220329184842.aXd896C7IkIjCnRxYIOwnPCTrApPQSFpnfi7OFAtcfU@z> (raw)
In-Reply-To: <89773980-593c-727a-28c9-d3304cd1aa78@codesourcery.com>
Hi Tobias,
Am 29.03.22 um 09:14 schrieb Tobias Burnus:
> Hi Harald,
>
> On 28.03.22 22:03, Harald Anlauf via Fortran wrote:
>> All current cases of printing a HOST_WIDE_INT in gcc/fortran/ use
>> 'sprintf', and I did not find any other use of %wd/%wu. So the
>> mentioned implementation is not really stressed yet... ;-)
>
> That's all your fault ;-)
true; I'm pleading guilty for that one.
> (Your commit
> https://gcc.gnu.org/r12-3273-ge4cb3bb9ac11b4126ffa718287dd509a4b10a658
> did remove the only user.)
I've now made good for it. ;-)
> That's only a warning. Have you tried whether it works at runtime?
> My bet is that it does!
Yes, it did work, it was just the warning alerting me ...
> Question: Do you build with --disable-bootstrap ? Or do you do a proper
> bootstrap?
... because I did build with --disable-bootstrap to save on time for
building the compiler on my local machine, and the system's default
gcc is older.
> Can you check & try again? I don't mind getting a format warning with
> GCC < GCC 12. But with GCC 12 compiled (either installed compiler or
> when bootstrapping) it should compile without errors.
>
> If you can confirm my suspicion, the patch LGTM.
I've just pushed that version as
https://gcc.gnu.org/g:0712f356374c2cf26015cccfa3141537e42cbb12
Sorry for the noise, and thanks for the review!
Harald
> Tobias
next prev parent reply other threads:[~2022-03-29 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 19:44 Harald Anlauf
2022-03-28 10:05 ` Tobias Burnus
2022-03-28 20:03 ` Harald Anlauf
2022-03-28 20:03 ` Harald Anlauf
2022-03-28 21:08 ` Harald Anlauf
2022-03-28 21:08 ` Harald Anlauf
2022-03-28 21:52 ` Joseph Myers
2022-03-29 7:14 ` Tobias Burnus
2022-03-29 18:48 ` Harald Anlauf [this message]
2022-03-29 18:48 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=886bfd00-2ffb-8568-0920-ee48434c92ef@gmx.de \
--to=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).