Re: [PATCH] PR fortran/84519 - [F2018] STOP and ERROR STOP statements with QUIET specifier

[Harald Anlauf <anlauf@gmx.de>]

Dear Jerry, Mikael,

thanks for the feedback!

Am 24.02.22 um 12:50 schrieb Mikael Morin:
> Le 23/02/2022 à 23:21, Harald Anlauf via Fortran a écrit :
>> Dear Fortranners,
>>
>> Fortran 2018 added a QUIET= specifier to STOP and ERROR STOP statements.
>> Janne already implemented the library side code four (4!) years ago,
>> but so far the frontend implementation was missing.
>>
>> Furthermore, F2018 allows for non-default-integer stopcode expressions
>> (finally!).
>>
>> The attached patch provides this implementation.
>>
>> That was not too much fun for the following reasons:
>>
>> - fixed format vs. free format
>> - F95 and F2003 apparently did not require a blank between STOP and
>>    stopcode, while F2008+ do require it.
>>
>> This should explain for the three testcases.
>>
>> Regtested on x86_64-pc-linux-gnu.  OK for mainline?
>>
>> One step closer to F2018!
>>
> Please move the error from trans-stmt.cc to resolve.cc.

That is certainly cleaner.  I've done this and rerun the regtest.

As suggested by Jerry a simple run-time testcase with QUIET=.true. has
been added.  However, since I could not find a way to convince dejagnu
that there should be no output, I simply check that the right values
are passed to the runtime library.

If somebody knows how to solve this and feels strongly about this,
please proceed.

Pushed as https://gcc.gnu.org/g:916b809fbfdd2740006270baf549bf22fe9ec3c4

> Otherwise looks good, and you have a green light by Jerry, but I would 
> rather defer this to gcc-13.
> 
> Mikael
> 

Thanks,
Harald