public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
* [Bug general/3721] New: Add ISA <-> Elf map, eliminate switch
@ 2006-12-14 16:09 cagney at redhat dot com
2006-12-14 17:20 ` [Bug general/3721] " cagney at redhat dot com
0 siblings, 1 reply; 2+ messages in thread
From: cagney at redhat dot com @ 2006-12-14 16:09 UTC (permalink / raw)
To: frysk-bugzilla
The file IsaFactory contains:
ElfEHeader header = elfFile.getEHeader();
switch (header.machine)
{
case ElfEMachine.EM_386:
{
if (frysk.core.Build.BUILD_ARCH.equals("i686"))
return LinuxIa32.isaSingleton ();
else
return LinuxIa32On64.isaSingleton();
}
case ElfEMachine.EM_PPC:
{
// Assume we do not build 32-bit frysk on ppc64.
if (frysk.core.Build.BUILD_ARCH.equals("powerpc64"))
return LinuxPPC32On64.isaSingleton ();
else
return LinuxPPC.isaSingleton ();
}
case ElfEMachine.EM_PPC64:
return LinuxPPC64.isaSingleton ();
case ElfEMachine.EM_X86_64:
return LinuxX8664.isaSingleton ();
default:
throw new TaskException("Unknown machine type " + header.machine);
}
instead the IsaFactory (called ElfIsa????) should contain a hash table mapping
Elf.MACHINE/Elf.ENDIAN/Elf.WORDSIZE <-> a corresponding ISA object and then use
that.
That way, given an ISA, the corresponding Elf info can be found - see fcore; and
given the Elf info the corresponding ISA can be found - see the existing code.
--
Summary: Add ISA <-> Elf map, eliminate switch
Product: frysk
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: frysk-bugzilla at sourceware dot org
ReportedBy: cagney at redhat dot com
CC: pmuldoon at redhat dot com
OtherBugsDependingO 2234,3387
nThis:
http://sourceware.org/bugzilla/show_bug.cgi?id=3721
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [Bug general/3721] Add ISA <-> Elf map, eliminate switch
2006-12-14 16:09 [Bug general/3721] New: Add ISA <-> Elf map, eliminate switch cagney at redhat dot com
@ 2006-12-14 17:20 ` cagney at redhat dot com
0 siblings, 0 replies; 2+ messages in thread
From: cagney at redhat dot com @ 2006-12-14 17:20 UTC (permalink / raw)
To: frysk-bugzilla
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|frysk-bugzilla at sourceware|timoore at redhat dot com
|dot org |
Status|NEW |ASSIGNED
http://sourceware.org/bugzilla/show_bug.cgi?id=3721
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-12-14 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-14 16:09 [Bug general/3721] New: Add ISA <-> Elf map, eliminate switch cagney at redhat dot com
2006-12-14 17:20 ` [Bug general/3721] " cagney at redhat dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).