From: Mark Wielaard <mark@klomp.org>
To: tromey@redhat.com
Cc: Frysk List <frysk@sourceware.org>
Subject: Re: minor frysk cleanup
Date: Sat, 01 Mar 2008 18:16:00 -0000 [thread overview]
Message-ID: <1204395396.3279.31.camel@localhost.localdomain> (raw)
In-Reply-To: <m38x13jz13.fsf@fleche.redhat.com>
Hi Tom,
On Fri, 2008-02-29 at 13:19 -0700, Tom Tromey wrote:
> I was looking at frysk a little today and noticed an oddity in
> FlowControlWriter. This class keeps its own copy of the output
> writer, but there is no reason to do this. FilterWriter subclasses
> should either use super calls or the inherited "out" field.
>
> frysk-core/frysk/util/ChangeLog:
> 2008-02-29 Tom Tromey <tromey@redhat.com>
>
> * FlowControlWriter.java (outStream): Remove.
> (FlowControlWriter): Update.
> (flush): Update.
> (close): Update.
> (write(char[],int,int)): Update.
> (write(int)): Update.
> (write(String,int,int)): Update.
This looks good. Thanks.
If you have git push access please push it.
Otherwise I can do that for you.
It does help if you run make check in at least frysk-core (or make check
-k toplevel) and mention whether you see any failures (normally we
should have zero fails, at least in frysk-core).
Cheers,
Mark
next prev parent reply other threads:[~2008-03-01 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 21:10 Tom Tromey
2008-03-01 18:16 ` Mark Wielaard [this message]
2008-03-01 18:27 ` Tom Tromey
2008-03-01 19:22 ` Mark Wielaard
2008-03-01 19:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204395396.3279.31.camel@localhost.localdomain \
--to=mark@klomp.org \
--cc=frysk@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).