Re: minor frysk cleanup

[Mark Wielaard <mark@klomp.org>]

Hi Tom,

On Sat, 2008-03-01 at 10:37 -0700, Tom Tromey wrote:
> Mark> This looks good. Thanks.
> Mark> If you have git push access please push it.
> Mark> Otherwise I can do that for you.
> 
> I don't think I do.

OK, I pushed it for you.

> Mark> It does help if you run make check in at least frysk-core (or make check
> Mark> -k toplevel) and mention whether you see any failures (normally we
> Mark> should have zero fails, at least in frysk-core).
> 
> I will run it now.

As discussed on irc there are currently some failures :{
Those are not supposed to be there of course, normally we are pretty
good at staying at zero fail. I checked that there were no regressions
with your patch applied (same results before/after).

Thanks,

Mark

Just for the record this is the failure list from frysk-core
(fedora 8, x86):

There were 2 unsupported:
  disassembler
  requires both 32-bit and 64-bit
There were 3 failures:
1)
testComplexStruct(frysk.value.TestClass)junit.framework.ComparisonFailure: Variable is a struct expected:<struct> but was:<class>
   at frysk.value.TestClass.testComplexStruct(TestRunner)
   at frysk.junit.Runner.runCases(TestRunner)
   at frysk.junit.Runner.runTestCases(TestRunner)
   at TestRunner.main(TestRunner)
2)
testInheritedStruct(frysk.value.TestClass)junit.framework.ComparisonFailure: Variable is a struct expected:<struct> but was:<class>
   at frysk.value.TestClass.testInheritedStruct(TestRunner)
   at frysk.junit.Runner.runCases(TestRunner)
   at frysk.junit.Runner.runTestCases(TestRunner)
   at TestRunner.main(TestRunner)
3)
testPublicPrivateType(frysk.value.TestComposite)junit.framework.ComparisonFailure: toPrint expected:<...public:
 ...> but was:<......>
   at frysk.value.TestComposite.testPublicPrivateType(TestRunner)
   at frysk.junit.Runner.runCases(TestRunner)
   at frysk.junit.Runner.runTestCases(TestRunner)
   at TestRunner.main(TestRunner)

FAILURES!!!
Tests run: 981,  Failures: 3,  Errors: 0

Failed after run #0
Exception in thread "main" FAIL: TestRunner
java.lang.NullPointerException
   at FunitSimpleInterfaceTest.main(FunitSimpleInterfaceTest.java:46)
Exception in thread "main" java.lang.NullPointerException
   at FunitSimpleInterfaceTest.main(FunitSimpleInterfaceTest.java:46)
FAIL: frysk/pkglibdir/FunitSimpleInterfaceTest
no suitable method `main' in class
FAIL: frysk/rt/TestDisplayValue