Re: Patch: word-wrapping for 'help' output

[Mark Wielaard <mark@klomp.org>]

Hi Tom,

On Sat, 2008-03-01 at 16:26 -0700, Tom Tromey wrote:
> Mark> This could use a method description.
> 
> You'll forgive me for assuming that the frysk style was not to write
> javadoc.

Documentation is really important. Especially later on when you look bad
at code you might not have written yourself and try to figure out what
and why it actually works. In this case I should probably have added it
myself since I was reviewing the code anyway. Sorry I was a bit lazy.
And thanks for picking it up!

> Here's an add-on patch that adds javadoc.  Let me know what you think.
> I guess I should learn git enough to supply consolidated patches.

This looks great! Don't worry too much about consolidating the patches.
I'll commit them separately on top of each other and then push them in
one go. It only really matter if the intermediate commits are bad (so
you cannot bisect through them when searching when something broke).
Some more git info and references can be found at:
http://sourceware.org/frysk/build/git-fu.html

> b/frysk-core/frysk/hpd/ChangeLog:
> 2008-03-01  Tom Tromey  <tromey@redhat.com>
> 
> 	* CLI.java (getWordWrapWriter): Document.
> 
> b/frysk-core/frysk/util/ChangeLog:
> 2008-03-01  Tom Tromey  <tromey@redhat.com>
> 
> 	* WordWrapWriter.java: Document.

Committed and will be pushed soon.

Thanks,

Mark