From: Mark Wielaard <mark@klomp.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Frysk List <frysk@sourceware.org>
Subject: Re: Patch: word-wrapping for 'help' output
Date: Sun, 02 Mar 2008 12:48:00 -0000 [thread overview]
Message-ID: <1204462060.8622.20.camel@localhost.localdomain> (raw)
In-Reply-To: <m37igmf1ew.fsf@fleche.redhat.com>
Hi Tom,
On Sat, 2008-03-01 at 16:51 -0700, Tom Tromey wrote:
> Mark> The CLI doesn't have the PtyTerminal (created in fhpd.java).
> Mark> It might make sense to pass that to the CLI so it can use
> Mark> getTerminalWidth() here when constructing the WordWrapWriter.
>
> Here's a patch to do it -- but *don't* check this in.
>
> getTerminalWidth seems to return something bogus, because everything
> started wrapping at column 20. I didn't look into this any more
> deeply.
Hmmm. Might be a bug in jline I guess.
I filed a bug for this issue pointing to this patch.
http://sourceware.org/bugzilla/show_bug.cgi?id=5817
And a separate one for upgrading our jline in frysk-imports.
http://sourceware.org/bugzilla/show_bug.cgi?id=5816
Hopefully it contains a fix. I didn't check though. We are still using a
fairly old 0.6 release of jline, while current upstream is 0.9.3. Tim
might know the story. I believe a newer version didn't compile cleanly
and had to be reverted just before we pulled from git for a fedora
release.
Cheers,
Mark
next prev parent reply other threads:[~2008-03-02 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 21:18 Tom Tromey
2008-03-01 22:04 ` Mark Wielaard
2008-03-02 0:17 ` Tom Tromey
2008-03-02 12:34 ` Mark Wielaard
2008-03-02 0:42 ` Tom Tromey
2008-03-02 12:48 ` Mark Wielaard [this message]
2008-03-02 16:10 ` Tom Tromey
2008-03-02 22:05 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204462060.8622.20.camel@localhost.localdomain \
--to=mark@klomp.org \
--cc=frysk@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).