public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
* TestLeakingFileDescriptor
@ 2007-07-31  2:13 Kris Van Hees
  2007-07-31 11:00 ` TestLeakingFileDescriptor Mark Wielaard
  2007-07-31 13:35 ` TestLeakingFileDescriptor Andrew Cagney
  0 siblings, 2 replies; 3+ messages in thread
From: Kris Van Hees @ 2007-07-31  2:13 UTC (permalink / raw)
  To: frysk

I'd like to propose that the TestLeakingFileDescriptor test cases be marked
as stress tests rather than regular tests, to avoid them being executed at
every testsuite invocation.  Reason for this proposal is two-fold: first of
all, these tests are implicitly intermittent due to the fact that they depend
on a behaviour that is not deterministic (the garbage collector does not
actually do I/O resource mangement), and secondly, when they do fail they tend
to cause a bunch of side effects (causing later tests to fail, causing daemon
instances of TestRunner to never get torn down, ...).

	Cheers,
	Kris

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: TestLeakingFileDescriptor
  2007-07-31  2:13 TestLeakingFileDescriptor Kris Van Hees
@ 2007-07-31 11:00 ` Mark Wielaard
  2007-07-31 13:35 ` TestLeakingFileDescriptor Andrew Cagney
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2007-07-31 11:00 UTC (permalink / raw)
  To: Kris Van Hees; +Cc: frysk

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

Hi Kris,

On Mon, 2007-07-30 at 22:11 -0400, Kris Van Hees wrote:
> I'd like to propose that the TestLeakingFileDescriptor test cases be marked
> as stress tests rather than regular tests, to avoid them being executed at
> every testsuite invocation.  Reason for this proposal is two-fold: first of
> all, these tests are implicitly intermittent due to the fact that they depend
> on a behaviour that is not deterministic (the garbage collector does not
> actually do I/O resource mangement), and secondly, when they do fail they tend
> to cause a bunch of side effects (causing later tests to fail, causing daemon
> instances of TestRunner to never get torn down, ...).

I think that is a good idea since the test results are pretty flaky as
they are now making comparing test runs pretty hard. I known good set of
tests that always PASS and that you don't have to second guess would be
really helpful. Only issue I can see is that if the stress tests are
optional people will never run them, but I guess that is what the
autobuilder/tester is for.

Cheers,

Mark

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: TestLeakingFileDescriptor
  2007-07-31  2:13 TestLeakingFileDescriptor Kris Van Hees
  2007-07-31 11:00 ` TestLeakingFileDescriptor Mark Wielaard
@ 2007-07-31 13:35 ` Andrew Cagney
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2007-07-31 13:35 UTC (permalink / raw)
  To: Kris Van Hees; +Cc: frysk

It is very hard to comment on a technical when the technical background 
is limited.  Can you please provide an example of the problem, perhaps 
reduced to an automated test-case?  As they say, they pass for me.

Is your testbed the motivation behind this request?  We can certainly 
explore options such as moving some of the tests to the stress 
test-suite; however the quid-pro-quo is that we have also analyzed 
failing cases identified by the stress test and added deterministic 
fixes for them.

Andrew

Kris Van Hees wrote:
> I'd like to propose that the TestLeakingFileDescriptor test cases be marked
> as stress tests rather than regular tests, to avoid them being executed at
> every testsuite invocation.  Reason for this proposal is two-fold: first of
> all, these tests are implicitly intermittent due to the fact that they depend
> on a behaviour that is not deterministic (the garbage collector does not
> actually do I/O resource mangement), and secondly, when they do fail they tend
> to cause a bunch of side effects (causing later tests to fail, causing daemon
> instances of TestRunner to never get torn down, ...).
>
> 	Cheers,
> 	Kris
>   

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-07-31 13:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-31  2:13 TestLeakingFileDescriptor Kris Van Hees
2007-07-31 11:00 ` TestLeakingFileDescriptor Mark Wielaard
2007-07-31 13:35 ` TestLeakingFileDescriptor Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).