From: Phil Muldoon <pmuldoon@redhat.com>
To: frysk@sourceware.org
Subject: Re: frysk-core/frysk/util ChangeLog CoredumpAction ...
Date: Tue, 31 Jul 2007 23:34:00 -0000 [thread overview]
Message-ID: <46AFC6F0.2030606@redhat.com> (raw)
In-Reply-To: <20070731232332.21734.qmail@sourceware.org>
Awhile back, when we were first working on fcore, Yong Zheng from IBM
came up with the idea what we make a factory for the note segments and
other various architecture specific sections. This would allow us to
separate the architecture specific sections into their own classes. For
reasons I cannot remember, we did not move that way and continued using
one class. I've not heard from Yong in awhile, but credit where credit
is due for the original idea. I re-factored these classes last week,
created the factory and client classes and tested them on x86 and
x86_64. If someone has PPC32 and PPC64 hardware, please let me know the
results.
I'm not sure all these client classes belong in the util/ namespace, and
will likely be moved somewhere more appropriate in the future. This, and
the re-factor, is part one of the CoredumpAction improvements. Now the
code is cleaner, the next step it to move towards a streaming model for
segments
Regards
Phil
pmuldoon@sourceware.org wrote:
> CVSROOT: /cvs/frysk
> Module name: frysk-core
> Changes by: pmuldoon@sourceware.org 2007-07-31 23:23:32
>
> Modified files:
> frysk/util : ChangeLog CoredumpAction.java
> Added files:
> frysk/util : LinuxElfCorefile.java
> LinuxElfCorefileFactory.java
> LinuxElfCorefilePPC32.java
> LinuxElfCorefilePPC32on64.java
> LinuxElfCorefilePPC64.java
> LinuxElfCorefilex86.java
> LinuxElfCorefilex8664.java
>
> Log message:
> 2007-07-31 Phil Muldoon <pmuldoon@localhost.localdomain>
>
> * CoredumpAction.java: Rewritten and Refactored to
> LinuxElfCorefile.java.
> * LinuxElfCorefileFactory.java: New. Return correct core
> file back-end.
> * LinuxCoreFile.java: New file.
> * LinuxCoreFilex86.java: New file.
> * LinuxCoreFilex8664.java: New file.
> * LinuxCoreFilePPC32.java: New file.
> * LinuxCoreFilePPC32On64.java: New file.
> * LinuxCoreFilePPC64.java: New file.
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefile.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefileFactory.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC32.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC32on64.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC64.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilex86.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilex8664.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/ChangeLog.diff?cvsroot=frysk&r1=1.154&r2=1.155
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/CoredumpAction.java.diff?cvsroot=frysk&r1=1.18&r2=1.19
>
>
parent reply other threads:[~2007-07-31 23:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20070731232332.21734.qmail@sourceware.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AFC6F0.2030606@redhat.com \
--to=pmuldoon@redhat.com \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).