Re: frysk-core/frysk/util ChangeLog CoredumpAction ...

Re: frysk-core/frysk/util ChangeLog CoredumpAction ...

[Phil Muldoon]

Awhile back, when we were first working on fcore, Yong Zheng from IBM 
came up with the idea what we make a factory for the note segments and 
other various architecture specific sections. This would allow us to 
separate the architecture specific sections into their own classes. For 
reasons I cannot remember, we did not move that way and continued using 
one class. I've not heard from Yong in awhile, but credit where credit 
is due for the original idea. I re-factored these classes last week, 
created the factory and client classes and tested them on x86 and 
x86_64. If someone has PPC32 and PPC64 hardware, please let me know the 
results.

I'm not sure all these client classes belong in the util/ namespace, and 
will likely be moved somewhere more appropriate in the future. This, and 
the re-factor, is part one of the CoredumpAction improvements. Now the 
code is cleaner, the next step it to move towards a streaming model for 
segments

Regards

Phil


pmuldoon@sourceware.org wrote:
> CVSROOT:	/cvs/frysk
> Module name:	frysk-core
> Changes by:	pmuldoon@sourceware.org	2007-07-31 23:23:32
>
> Modified files:
> 	frysk/util     : ChangeLog CoredumpAction.java 
> Added files:
> 	frysk/util     : LinuxElfCorefile.java 
> 	                 LinuxElfCorefileFactory.java 
> 	                 LinuxElfCorefilePPC32.java 
> 	                 LinuxElfCorefilePPC32on64.java 
> 	                 LinuxElfCorefilePPC64.java 
> 	                 LinuxElfCorefilex86.java 
> 	                 LinuxElfCorefilex8664.java 
>
> Log message:
> 	2007-07-31  Phil Muldoon  <pmuldoon@localhost.localdomain>
> 	
> 	* CoredumpAction.java: Rewritten and Refactored to
> 	LinuxElfCorefile.java.
> 	* LinuxElfCorefileFactory.java: New. Return correct core
> 	file back-end.
> 	* LinuxCoreFile.java: New file.
> 	* LinuxCoreFilex86.java: New file.
> 	* LinuxCoreFilex8664.java: New file.
> 	* LinuxCoreFilePPC32.java: New file.
> 	* LinuxCoreFilePPC32On64.java: New file.
> 	* LinuxCoreFilePPC64.java: New file.
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefile.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefileFactory.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC32.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC32on64.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilePPC64.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilex86.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/LinuxElfCorefilex8664.java.diff?cvsroot=frysk&r1=NONE&r2=1.1
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/ChangeLog.diff?cvsroot=frysk&r1=1.154&r2=1.155
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/util/CoredumpAction.java.diff?cvsroot=frysk&r1=1.18&r2=1.19
>
>