* adding print methods to frysk.value.Format
@ 2007-08-14 16:41 Andrew Cagney
0 siblings, 0 replies; only message in thread
From: Andrew Cagney @ 2007-08-14 16:41 UTC (permalink / raw)
To: frysk
Just FYI,
I've gone through the code and removed a number of cases where
frysk.value.Format was being treated as an enum, for instance:
if (format == Format.HEXACECIMAL)
print as hex
else if (format == Format.DECIMAL)
print as decimal
...
(and similarly for the Type's typeId). This should instead be
implemented by extending Format to handle the type in question, for
instance:
format.printPointer(PrintWriter, location-of-data)
While there were no test-suite regressions, I suspect, as the better
implemented code is filled in, there may be some lurking untested
user-visible regressions.
Andrew
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-08-14 16:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-08-14 16:41 adding print methods to frysk.value.Format Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).