Re: fhpd vs RuntimeExceptions

[Andrew Cagney <cagney@redhat.com>]

Mark Wielaard wrote:
> Forgot:
>
> On Thu, 2007-11-15 at 17:01 +0000, Phil Muldoon wrote:
>   
>> Pending a the full implementation of this it's a pain to see every 
>> single exception printed.
>>     
>
> Till there is a difference between fatal and user message "exceptions"
> you can easily get the old behavior by tweaking CLI.flushMessages():
>
>   
That unfortunatly isn't sufficient; the old code in CLI.java was 
differentiating between and NPE and other exceptions - dumping the stack 
when an NPE occured.  I'll restore this behavior; so we're at least back 
to a usable status quo (and from a HPD user prospective in a better 
position - these back-traces plain suck)

I'll also add a prototype version of CLI.printError() that we discussed; 
and have just EvalCommands use it; we can then refine it as needed.

Andrew

> --- a/frysk-core/frysk/hpd/CLI.java
> +++ b/frysk-core/frysk/hpd/CLI.java
> @@ -294,7 +294,7 @@ public class CLI {
>                  outWriter.print(prefix);
>              outWriter.println(tempmsg.getMessage());
>             Throwable exc = tempmsg.getException();
> -           if (exc != null)
> +           if (exc != null && false)
>                 exc.printStackTrace(outWriter);
>              iter.remove();
>          }
>
> Or replace false with the heuristic you find acceptable of course.
>
> Cheers,
>
> Mark
>
>