* Re: [SCM] master: Updating register group names. [not found] <20071204110100.9581.qmail@sourceware.org> @ 2007-12-04 13:34 ` Mark Wielaard 2007-12-04 14:57 ` Andrew Cagney 0 siblings, 1 reply; 2+ messages in thread From: Mark Wielaard @ 2007-12-04 13:34 UTC (permalink / raw) To: frysk; +Cc: Jose Flavio Aguilar Paulino Hi Jose, On Tue, 2007-12-04 at 11:01 +0000, jflavio@sourceware.org wrote: > Author: Jose Flavio Aguilar Paulino <joseflavio@gmail.com> > Date: Tue Dec 4 08:45:03 2007 -0200 > > Updating register group names. This does break one test: testToString(frysk.isa.TestISA)junit.framework.ComparisonFailure: toString expected:<...> but was:<...32BE> > public static final ISA PPC32BE > - = new ISA(ByteOrder.BIG_ENDIAN, 4, "PowerPC"); > + = new ISA(ByteOrder.BIG_ENDIAN, 4, "PowerPC32BE"); > public static final ISA PPC64BE > - = new ISA(ByteOrder.BIG_ENDIAN, 8, "PowerPC"); > + = new ISA(ByteOrder.BIG_ENDIAN, 8, "PowerPC64BE"); I am not sure what the right String is. But it should be similar in both the isa and the test. Cheers, Mark ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [SCM] master: Updating register group names. 2007-12-04 13:34 ` [SCM] master: Updating register group names Mark Wielaard @ 2007-12-04 14:57 ` Andrew Cagney 0 siblings, 0 replies; 2+ messages in thread From: Andrew Cagney @ 2007-12-04 14:57 UTC (permalink / raw) To: Mark Wielaard, Jose Flavio Aguilar Paulino; +Cc: frysk Mark Wielaard wrote: > Hi Jose, > > On Tue, 2007-12-04 at 11:01 +0000, jflavio@sourceware.org wrote: > >> Author: Jose Flavio Aguilar Paulino <joseflavio@gmail.com> >> Date: Tue Dec 4 08:45:03 2007 -0200 >> >> Updating register group names. >> > > This does break one test: > > testToString(frysk.isa.TestISA)junit.framework.ComparisonFailure: > toString expected:<...> but was:<...32BE> > > >> public static final ISA PPC32BE >> - = new ISA(ByteOrder.BIG_ENDIAN, 4, "PowerPC"); >> + = new ISA(ByteOrder.BIG_ENDIAN, 4, "PowerPC32BE"); >> public static final ISA PPC64BE >> - = new ISA(ByteOrder.BIG_ENDIAN, 8, "PowerPC"); >> + = new ISA(ByteOrder.BIG_ENDIAN, 8, "PowerPC64BE"); >> > > I am not sure what the right String is. But it should be similar in both > the isa and the test. > Just "PowerPC", the string specifies the the ISA family. Thing's like "big-endian" and 64-bit are derived from the other parameters. The test looks like this: public void testToString() { assertEquals("toString", "32-bit big-endian PowerPC", ISA.PPC32BE.toString()); } Andrew > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-04 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20071204110100.9581.qmail@sourceware.org>
2007-12-04 13:34 ` [SCM] master: Updating register group names Mark Wielaard
2007-12-04 14:57 ` Andrew Cagney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).