From: Andrew Cagney <cagney@redhat.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: frysk@sourceware.org
Subject: Re: [SCM] master: Add frysk.rsl loggin.
Date: Tue, 12 Feb 2008 21:33:00 -0000 [thread overview]
Message-ID: <47B2102D.2030804@redhat.com> (raw)
In-Reply-To: <20080212200324.2256.qmail@sourceware.org>
Phil,
There's a less leaky way to write this (if a specific sequence is
missing in Log, just add it).
> {
>
> +
> + finest.log(this,"peek() address 0x" + Long.toHexString(address));
>
finest.log(this, "peak() address", address);
> byte[] buffer = new byte[1];
> MapAddressHeader metaLine = findMetaData(address);
>
> @@ -120,6 +125,10 @@ public class CorefileByteBuffer
> StatelessFile temp = new StatelessFile(new File(metaLine.name));
> long offset = metaLine.solibOffset + (address - metaLine.vaddr);
> temp.pread(offset, buffer,0,1);
> + finest.log(this,"peek'ed() 0x"+Integer.toHexString(buffer[0] & 0xff) +
> + " from address 0x"+Long.toHexString(address) +
> + " offset 0x"+Long.toHexString(offset) +
> + " from file: " +metaLine.name);
>
finest.log(this, "peek'ed ", (long)(buffer[0]&0xff), "from address",
address, "offset", offset, "file", metaLine.name);
and so on. All log functions take the consistent form:
log(SELF, MESSAGE, OBJECT, MESSAGE, OBJECT, ....)
Andrew
next parent reply other threads:[~2008-02-12 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080212200324.2256.qmail@sourceware.org>
2008-02-12 21:33 ` Andrew Cagney [this message]
2008-02-13 10:18 ` Phil Muldoon
2008-02-13 16:48 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47B2102D.2030804@redhat.com \
--to=cagney@redhat.com \
--cc=frysk@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).