* A bug fix for common symbol in the ELF linker? [not found] <199510031557.LAA00698@huahaga.rutgers.edu> @ 1995-10-03 19:26 ` H.J. Lu 1995-10-03 19:33 ` Ian Lance Taylor 0 siblings, 1 reply; 2+ messages in thread From: H.J. Lu @ 1995-10-03 19:26 UTC (permalink / raw) To: David S. Miller; +Cc: Ian Lance Taylor, gas2 Hi, This is the patch for the common symbol bug in ELF I reported earlier. I hope it won't break anything. Thanks. H.J. =================================================================== RCS file: /home/cvs/gnu/binutils/bfd/elflink.h,v retrieving revision 1.3 diff -c -r1.3 elflink.h *** 1.3 1995/08/24 01:32:34 --- elflink.h 1995/10/04 02:15:07 *************** *** 153,159 **** false, false, false); if (h == (struct elf_link_hash_entry *) NULL) continue; ! if (h->root.type != bfd_link_hash_undefined) { if (h->root.type != bfd_link_hash_undefweak) defined[i] = true; --- 153,161 ---- false, false, false); if (h == (struct elf_link_hash_entry *) NULL) continue; ! /* We should check both undef and common symbols. H.J. */ ! if (h->root.type != bfd_link_hash_undefined && ! h->root.type != bfd_link_hash_common) { if (h->root.type != bfd_link_hash_undefweak) defined[i] = true; ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: A bug fix for common symbol in the ELF linker? 1995-10-03 19:26 ` A bug fix for common symbol in the ELF linker? H.J. Lu @ 1995-10-03 19:33 ` Ian Lance Taylor 0 siblings, 0 replies; 2+ messages in thread From: Ian Lance Taylor @ 1995-10-03 19:33 UTC (permalink / raw) To: hjl; +Cc: davem, gas2 From: hjl@nynexst.com (H.J. Lu) Date: Tue, 3 Oct 95 22:26:51 EDT This is the patch for the common symbol bug in ELF I reported earlier. I hope it won't break anything. I don't understand this. I thought I explained why it was not a bug. Solaris notwithstanding, ELF doesn't work that way. I may have misunderstood your response. Did you disagree with my explanation? Ian ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~1995-10-03 19:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <199510031557.LAA00698@huahaga.rutgers.edu>
1995-10-03 19:26 ` A bug fix for common symbol in the ELF linker? H.J. Lu
1995-10-03 19:33 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).