public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz> To: rguenther at suse dot de <gcc-bugzilla@gcc.gnu.org> Cc: gcc-bugs@gcc.gnu.org Subject: Re: [Bug tree-optimization/106293] [13/14 Regression] 456.hmmer at -Ofast -march=native regressed by 19% on zen2 and zen3 in July 2022 Date: Fri, 28 Jul 2023 10:01:04 +0200 [thread overview] Message-ID: <ZMN1wMwl7jipXL4Q@kam.mff.cuni.cz> (raw) In-Reply-To: <bug-106293-4-UdlbHEaNfr@http.gcc.gnu.org/bugzilla/> > This heuristic wants to catch > > <sink stmt> > if (foo) abort (); > <place to sink> > > and avoid sinking "too far" across a path with "similar enough" > execution count (I think the original motivation was to fix some > spilling / register pressure issue). The loop depth test > should be !(bb_loop_depth (best_bb) < bb_loop_depth (early_bb)) I am still concenred that loop_depth (bb1) < loop_depth (bb2) does not really imply that bb1 is not in different loop nest with loop with significantly higher iteration count than bb2... > so we shouldn't limit sinking to a more outer nest. As we rule > out > before this becomes ==. > > It looks tempting to sink to the earliest place with the same > execution count rather than the latest but the above doesn't > really achive that (it doesn't look "upwards" but simply fails). > With a guessed profile it's also going to be hard. Statistically guessed profile works quite well for things like placement of splills in IRA (not perfectly of course) and this looks like kind of similar thing. So perhaps it could work reasoably well... > > And it in no way implements register pressure / spilling sensitivity > (see also Ajits attempts at producing a patch that avoids sinking > across a call). All these are ultimatively doomed unless we at least > consider a group of stmts together. hmm, life is hard :) Honza
next prev parent reply other threads:[~2023-07-28 8:01 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-14 9:08 [Bug tree-optimization/106293] New: " jamborm at gcc dot gnu.org 2022-07-14 9:22 ` [Bug tree-optimization/106293] [13 Regression] " rguenth at gcc dot gnu.org 2022-07-14 12:10 ` rguenth at gcc dot gnu.org 2022-07-14 12:22 ` rguenth at gcc dot gnu.org 2022-07-25 9:44 ` luoxhu at gcc dot gnu.org 2022-07-25 9:46 ` luoxhu at gcc dot gnu.org 2023-01-10 12:12 ` yann at ywg dot ch 2023-01-10 12:45 ` rguenth at gcc dot gnu.org 2023-01-10 15:53 ` cvs-commit at gcc dot gnu.org 2023-01-10 15:54 ` rguenth at gcc dot gnu.org 2023-01-11 7:04 ` cvs-commit at gcc dot gnu.org 2023-04-17 15:11 ` [Bug tree-optimization/106293] [13/14 " jakub at gcc dot gnu.org 2023-04-17 16:15 ` jamborm at gcc dot gnu.org 2023-04-26 6:56 ` rguenth at gcc dot gnu.org 2023-07-27 9:23 ` rguenth at gcc dot gnu.org 2023-07-27 18:01 ` hubicka at gcc dot gnu.org 2023-07-27 21:38 ` hubicka at gcc dot gnu.org 2023-07-28 7:22 ` rguenther at suse dot de 2023-07-28 8:01 ` Jan Hubicka [this message] 2023-07-28 7:51 ` cvs-commit at gcc dot gnu.org 2023-07-28 8:01 ` hubicka at ucw dot cz 2023-07-28 12:09 ` rguenther at suse dot de 2023-07-31 7:44 ` hubicka at gcc dot gnu.org 2023-07-31 15:39 ` jamborm at gcc dot gnu.org 2023-08-01 10:40 ` hubicka at gcc dot gnu.org 2023-08-02 8:48 ` hubicka at gcc dot gnu.org 2023-08-02 9:42 ` rguenth at gcc dot gnu.org 2023-08-04 10:09 ` [Bug tree-optimization/106293] [13 regression] " hubicka at gcc dot gnu.org 2023-08-07 8:56 ` cvs-commit at gcc dot gnu.org 2023-08-10 16:01 ` hubicka at gcc dot gnu.org 2024-05-21 9:11 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ZMN1wMwl7jipXL4Q@kam.mff.cuni.cz \ --to=hubicka@ucw.cz \ --cc=gcc-bugs@gcc.gnu.org \ --cc=gcc-bugzilla@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).