public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/106293] [13/14 Regression] 456.hmmer at -Ofast -march=native regressed by 19% on zen2 and zen3 in July 2022 Date: Thu, 27 Jul 2023 18:01:54 +0000 [thread overview] Message-ID: <bug-106293-4-1ZP5o66wDt@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106293-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106293 --- Comment #15 from Jan Hubicka <hubicka at gcc dot gnu.org> --- if (bb_loop_depth (best_bb) == bb_loop_depth (early_bb) /* If result of comparsion is unknown, prefer EARLY_BB. Thus use !(...>=..) rather than (...<...) */ - && !(best_bb->count * 100 >= early_bb->count * threshold)) + && !(best_bb->count * 100 > early_bb->count * threshold)) return best_bb; Comparing loop depths seems ceartainly odd. If we want to test best_bb and early_bb to be in same loop, we want to test loop_father. What is a benefit of testing across loop nests? Profile report here claims: dump id |static mismat|dynamic mismatch | |in count |in count |time | lsplit | 5 +5| 8151850567 +8151850567| 531506481006 +57.9%| ldist | 9 +4| 15345493501 +7193642934| 606848841056 +14.2%| ifcvt | 10 +1| 15487514871 +142021370| 689469797790 +13.6%| vect | 35 +25| 17558425961 +2070911090| 517375405715 -25.0%| cunroll | 42 +7| 16898736178 -659689783| 452445796198 -4.9%| loopdone| 33 -9| 2678017188 -14220718990| 330969127663 | tracer | 34 +1| 2678018710 +1522| 330613415364 +0.0%| fre | 33 -1| 2676980249 -1038461| 330465677073 -0.0%| expand | 28 -5| 2497468467 -179511782|--------------------------| so looks like loop splitting, distribution and vectorizer does disturb profile signficantly. (Ifcft does so by design and the damage is undone later.) Not sure if that is the real problem though.
next prev parent reply other threads:[~2023-07-27 18:01 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-14 9:08 [Bug tree-optimization/106293] New: " jamborm at gcc dot gnu.org 2022-07-14 9:22 ` [Bug tree-optimization/106293] [13 Regression] " rguenth at gcc dot gnu.org 2022-07-14 12:10 ` rguenth at gcc dot gnu.org 2022-07-14 12:22 ` rguenth at gcc dot gnu.org 2022-07-25 9:44 ` luoxhu at gcc dot gnu.org 2022-07-25 9:46 ` luoxhu at gcc dot gnu.org 2023-01-10 12:12 ` yann at ywg dot ch 2023-01-10 12:45 ` rguenth at gcc dot gnu.org 2023-01-10 15:53 ` cvs-commit at gcc dot gnu.org 2023-01-10 15:54 ` rguenth at gcc dot gnu.org 2023-01-11 7:04 ` cvs-commit at gcc dot gnu.org 2023-04-17 15:11 ` [Bug tree-optimization/106293] [13/14 " jakub at gcc dot gnu.org 2023-04-17 16:15 ` jamborm at gcc dot gnu.org 2023-04-26 6:56 ` rguenth at gcc dot gnu.org 2023-07-27 9:23 ` rguenth at gcc dot gnu.org 2023-07-27 18:01 ` hubicka at gcc dot gnu.org [this message] 2023-07-27 21:38 ` hubicka at gcc dot gnu.org 2023-07-28 7:22 ` rguenther at suse dot de 2023-07-28 8:01 ` Jan Hubicka 2023-07-28 7:51 ` cvs-commit at gcc dot gnu.org 2023-07-28 8:01 ` hubicka at ucw dot cz 2023-07-28 12:09 ` rguenther at suse dot de 2023-07-31 7:44 ` hubicka at gcc dot gnu.org 2023-07-31 15:39 ` jamborm at gcc dot gnu.org 2023-08-01 10:40 ` hubicka at gcc dot gnu.org 2023-08-02 8:48 ` hubicka at gcc dot gnu.org 2023-08-02 9:42 ` rguenth at gcc dot gnu.org 2023-08-04 10:09 ` [Bug tree-optimization/106293] [13 regression] " hubicka at gcc dot gnu.org 2023-08-07 8:56 ` cvs-commit at gcc dot gnu.org 2023-08-10 16:01 ` hubicka at gcc dot gnu.org 2024-05-21 9:11 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106293-4-1ZP5o66wDt@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).