public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/100366] spurious warning - std::vector::clear followed by std::vector::insert(vec.end(), ...) with -O2 Date: Tue, 04 May 2021 07:39:35 +0000 [thread overview] Message-ID: <bug-100366-4-UcjslSBleH@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-100366-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100366 --- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> --- The issue is that FRE sees <bb 2> [local count: 1073741824]: _6 = vec_2(D)->D.33436._M_impl.D.32749._M_start; _7 = vec_2(D)->D.33436._M_impl.D.32749._M_finish; if (_6 != _7) goto <bb 3>; [70.00%] else goto <bb 4>; [30.00%] <bb 3> [local count: 751619281]: vec_2(D)->D.33436._M_impl.D.32749._M_finish = _6; <bb 4> [local count: 1073741824]: _5 = MEM[(char * const &)vec_2(D) + 8]; so clearly _5 is _not_ equal to _7 but on the path 2 -> 3 -> 4 it is equal to _6. Only PRE transforms the load in _5 to a select of both (a PHI node): <bb 2> [local count: 1073741824]: _6 = vec_2(D)->D.33436._M_impl.D.32749._M_start; _7 = vec_2(D)->D.33436._M_impl.D.32749._M_finish; if (_6 != _7) goto <bb 4>; [70.00%] else goto <bb 3>; [30.00%] <bb 3> [local count: 322122544]: _86 = _7 - _6; _125 = (sizetype) _86; goto <bb 5>; [100.00%] <bb 4> [local count: 751619281]: vec_2(D)->D.33436._M_impl.D.32749._M_finish = _6; <bb 5> [local count: 1073741824]: # prephitmp_141 = PHI <_7(3), _6(4)> # prephitmp_83 = PHI <_86(3), 0(4)> # prephitmp_65 = PHI <_125(3), 0(4)> _21 = vec_2(D)->D.33436._M_impl.D.32749._M_end_of_storage; PRE also removes some partial redundancies here (the other two PHIs).
next prev parent reply other threads:[~2021-05-04 7:39 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-01 2:36 [Bug c++/100366] New: " mrsam@courier-mta.com 2021-05-02 11:27 ` [Bug tree-optimization/100366] " glisse at gcc dot gnu.org 2021-05-03 17:51 ` msebor at gcc dot gnu.org 2021-05-03 21:02 ` mrsam@courier-mta.com 2021-05-04 7:39 ` rguenth at gcc dot gnu.org [this message] 2021-05-05 10:55 ` glisse at gcc dot gnu.org 2021-05-05 11:01 ` glisse at gcc dot gnu.org 2021-05-05 11:15 ` glisse at gcc dot gnu.org 2021-05-05 12:18 ` mrsam@courier-mta.com 2021-05-12 23:44 ` msebor at gcc dot gnu.org 2021-12-02 21:14 ` msebor at gcc dot gnu.org 2021-12-06 16:45 ` [Bug tree-optimization/100366] [11/12 Regression] " roystgnr at ices dot utexas.edu 2021-12-28 12:09 ` pinskia at gcc dot gnu.org 2022-01-20 14:03 ` rguenth at gcc dot gnu.org 2022-04-21 7:49 ` rguenth at gcc dot gnu.org 2022-07-05 10:07 ` [Bug tree-optimization/100366] [11/12/13 " hewillk at gmail dot com 2022-11-26 15:53 ` zeranoe at gmail dot com 2022-11-29 15:58 ` redi at gcc dot gnu.org 2022-11-29 17:14 ` cvs-commit at gcc dot gnu.org 2023-04-20 13:57 ` [Bug tree-optimization/100366] [11/12 " cvs-commit at gcc dot gnu.org 2023-05-29 10:04 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-100366-4-UcjslSBleH@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).