[Bug target/100952] New: [12 regression] several test case failures after r12-1202

[Bug target/100952] New: [12 regression] several test case failures after r12-1202

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

            Bug ID: 100952
           Summary: [12 regression] several test case failures after
                    r12-1202
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

previous run: g:a3f6bd7891495a0ed65f7da7a55d36c730328692, r12-1201: 240
failures
this run    : g:9080a3bf23297885fdc47221da37a71d6dec93c5, r12-1202: 252
failures

FAIL: gcc.target/powerpc/fusion-p10-ldcmpi.c scan-assembler-times
lbz_cmpldi_cr0_QI_clobber_CCUNS_zero 2
FAIL: gcc.target/powerpc/fusion-p10-ldcmpi.c scan-assembler-times
lha_cmpdi_cr0_HI_clobber_CC_sign 8
FAIL: gcc.target/powerpc/fusion-p10-ldcmpi.c scan-assembler-times
lhz_cmpldi_cr0_HI_clobber_CCUNS_zero 2
FAIL: gcc.target/powerpc/fusion-p10-ldcmpi.c scan-assembler-times
lwa_cmpdi_cr0_SI_EXTSI_CC_sign 3
FAIL: gcc.target/powerpc/fusion-p10-ldcmpi.c scan-assembler-times
lwz_cmpldi_cr0_SI_EXTSI_CCUNS_zero 2
FAIL: gcc.target/powerpc/pr56605.c scan-rtl-dump-times combine "\\(compare:CC
\\((?:and|zero_extend):DI \\(reg:[SD]I" 1
FAIL: gcc.target/powerpc/pr81348.c scan-assembler \\mlxsihzx\\M
FAIL: gcc.target/powerpc/pr81348.c scan-assembler \\mvextsh2d\\M
FAIL: gcc.target/powerpc/prefix-no-update.c scan-assembler-times \\mlwz\\M 2
FAIL: gcc.target/powerpc/prefix-no-update.c scan-assembler-times \\mplwz\\M 2
FAIL: gcc.target/powerpc/prefix-no-update.c scan-assembler-times \\mpstw\\M 2
FAIL: gcc.target/powerpc/prefix-no-update.c scan-assembler-times \\mstw\\M 2

I am seeing these on both BE and LE and on all levels of powerp64 hardware.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #1 from seurer at gcc dot gnu.org ---
Also, this test 
FAIL: gfortran.dg/parity_1.f90   -O0  execution test
only fails on power 10.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[guihaoc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #2 from HaoChen Gui <guihaoc at gcc dot gnu.org> ---
For pr81348.c, the lxsihzx and vextsh2d are no long needed as the HI to DI mode
promotion is removed by my patch. The short could be loaded directly.

addis 9,2,.LANCHOR0+4@toc@ha
lha 9,.LANCHOR0+4@toc@l(9)

I plan to change the match instructions for this case.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[guihaoc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #3 from HaoChen Gui <guihaoc at gcc dot gnu.org> ---
For pr56605.c, the pseudo is not taken mode promotion. The original combined
insn
compare:CC (and:DI (reg:DI 206)
changes to
compare:CC (and:SI (subreg:SI (reg:DI 206) 0) 
So the dump scan fails. I will changed the case.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[guihaoc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #4 from HaoChen Gui <guihaoc at gcc dot gnu.org> ---
For fusion-p10-ldcmpi.c and prefix-no-update.c, the optimization doesn't work
when mode promotion is disabled. I will do further investigation.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug target/100952] [12 regression] several test case failures after r12-1202

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #5 from seurer at gcc dot gnu.org ---
*** Bug 101201 has been marked as a duplicate of this bug. ***

[Bug target/100952] [12 regression] several test case failures after r12-1202

[guihaoc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #6 from HaoChen Gui <guihaoc at gcc dot gnu.org> ---
Seurer,
  Could you provide detail info about test? Such as config and build option. I
tested the build on P10 and no failure on parity_1.f90. Thanks.
PASS: gfortran.dg/parity_1.f90   -O0  (test for excess errors)

[Bug target/100952] [12 regression] several test case failures after r12-1202

[guihaoc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #7 from HaoChen Gui <guihaoc at gcc dot gnu.org> ---
PASS: gfortran.dg/parity_1.f90   -O0  execution test

[Bug target/100952] [12 regression] several test case failures after r12-1202

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #8 from seurer at gcc dot gnu.org ---
I just tried with current trunk:

g:e0672017370b9a9362fda52ecffe33d1c9c41829, r12-1813
make  -k check-gcc-fortran RUNTESTFLAGS="dg.exp=gfortran.dg/parity_1.f90"
FAIL: gfortran.dg/parity_1.f90   -O0  execution test
# of expected passes            11
# of unexpected failures        1

My configure is pretty simple:  
/home/seurer/gcc/git/gcc-test/configure
--prefix=/home/seurer/gcc/git/install/gcc-test --enable-languages=c,fortran,c++
--with-cpu=power10 --disable-bootstrap
--with-as=/home/seurer/binutils/install/bin/as
--with-ld=/home/seurer/binutils/install/bin/ld
--with-ar=/home/seurer/binutils/install/bin/ar

The --with-XX things are to pick up the 2.36.1 version of binutils which is
also on my path.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by HaoChen Gui <guihaoc@gcc.gnu.org>:

https://gcc.gnu.org/g:3382846558e02044598556e66e5ea1cb3115429d

commit r12-2479-g3382846558e02044598556e66e5ea1cb3115429d
Author: Haochen Gui <guihaoc@gcc.gnu.org>
Date:   Fri Jul 23 09:47:23 2021 +0800

    Fix execution failure of parity_1.f90 on P10 [PR100952]

    gcc/
            PR target/100952
            * config/rs6000/rs6000.md (cstore<mode>4): Fix wrong fall through.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by HaoChen Gui <guihaoc@gcc.gnu.org>:

https://gcc.gnu.org/g:f0529d96f56758e56151f409c55bab3034163210

commit r12-2592-gf0529d96f56758e56151f409c55bab3034163210
Author: Haochen Gui <guihaoc@gcc.gnu.org>
Date:   Thu Jul 29 14:56:12 2021 +0800

    Fix failed test cases caused by disabling mode promotion for pseudos
[PR100952]

    gcc/testsuite
            PR target/100952
            * gcc.target/powerpc/pr56605.c: Change matching
            conditions.
            * gcc.target/powerpc/pr81348.c: Likewise.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by HaoChen Gui
<guihaoc@gcc.gnu.org>:

https://gcc.gnu.org/g:960135b264a7724cf9c56acb6d85fb2d842a36e2

commit r11-8824-g960135b264a7724cf9c56acb6d85fb2d842a36e2
Author: Haochen Gui <guihaoc@gcc.gnu.org>
Date:   Mon Aug 2 11:14:15 2021 +0800

    Fix execution failure of parity_1.f90 on P10 [PR100952]

    gcc/
            PR target/100952
            * config/rs6000/rs6000.md (cstore<mode>4): Fix wrong fall through.

    (cherry picked from commit 3382846558e02044598556e66e5ea1cb3115429d)

[Bug target/100952] [12 regression] several test case failures after r12-1202

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Segher Boessenkool
<segher@gcc.gnu.org>:

https://gcc.gnu.org/g:c27080718d480ef08986b9224c0d146b75791c25

commit r11-8941-gc27080718d480ef08986b9224c0d146b75791c25
Author: Haochen Gui <guihaoc@gcc.gnu.org>
Date:   Thu Jul 29 14:56:12 2021 +0800

    Fix failed test cases caused by disabling mode promotion for pseudos
[PR100952]

    gcc/testsuite
            PR target/100952
            * gcc.target/powerpc/pr56605.c: Change matching
            conditions.
            * gcc.target/powerpc/pr81348.c: Likewise.

    (cherry picked from commit f0529d96f56758e56151f409c55bab3034163210)

[Bug target/100952] [12 regression] several test case failures after r12-1202

[guihaoc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #13 from HaoChen Gui <guihaoc at gcc dot gnu.org> ---
Issue for fusion-p10-ldcmpi.c was fixed by r12-1655. 
https://gcc.gnu.org/pipermail/gcc-cvs/2021-June/349357.html

[Bug target/100952] [12 regression] several test case failures after r12-1202

[wschmidt at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

Bill Schmidt <wschmidt at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wschmidt at gcc dot gnu.org

--- Comment #14 from Bill Schmidt <wschmidt at gcc dot gnu.org> ---
Which tests are still failing?

[Bug target/100952] [12 regression] several test case failures after r12-1202

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #15 from seurer at gcc dot gnu.org ---
Looking through test results I see that gcc.target/powerpc/pr56605.c and
gcc.target/powerpc/prefix-no-update.c are still failing today.

[Bug target/100952] [12 regression] several test case failures after r12-1202

[guihaoc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

--- Comment #16 from HaoChen Gui <guihaoc at gcc dot gnu.org> ---
prefix-no-update.c should be fixed by the patch Segher proposed in PR103197.
pr56605.c got a wrong fixed and failed with GCC11. I will submit a patch to fix
it.

[Bug target/100952] [12/13 regression] several test case failures after r12-1202

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.0                        |12.2

--- Comment #17 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 12.1 is being released, retargeting bugs to GCC 12.2.

[Bug target/100952] [12/13 regression] several test case failures after r12-1202

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug target/100952] [12/13 regression] several test case failures after r12-1202

[guihaoc at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100952

HaoChen Gui <guihaoc at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #19 from HaoChen Gui <guihaoc at gcc dot gnu.org> ---
Closing as fixed then (pr56605.c still fails on older branches, but that is
harmless). Other issues are all fixed.