public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "segher at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/102239] powerpc suboptimal boolean test of contiguous bits Date: Wed, 24 Nov 2021 23:22:58 +0000 [thread overview] Message-ID: <bug-102239-4-Al77nCg8Od@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102239-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102239 --- Comment #3 from Segher Boessenkool <segher at gcc dot gnu.org> --- (In reply to luoxhu from comment #2) > (In reply to Segher Boessenkool from comment #1) > > Confirmed. > > > > So the relevant insn > > > > (parallel [(set (reg:CC 123) > > (compare:CC (and:DI (reg:DI 124) > > (const_int 25769803776 [0x600000000])) > > (const_int 0 [0]))) > > (clobber (scratch:DI))]) > > > > is matched by *and<mode>3_2insn but not by any pattern that ends up as just > > one insn. Not *and<mode>3_mask_dot, because that doesn't do a shift first, > > is just an AND and there are no machine insns to do that; but there is no > > pattern for what we can do. > > > > *rotl<mode>3_mask_dot cannot do this either; the base and the dot2 of that > > cannot be done, they return a shifted result, but that doesn't matter for > > comparing it to 0. So we should add a specialised version. > > Seems different with what you describe, in combine, it was combined to > anddi3_2insn_dot: > > (insn 9 8 10 2 (parallel [ > (set (reg:CC 122) > (compare:CC (and:DI (reg:DI 123) > (const_int 25769803776 [0x600000000])) > (const_int 0 [0]))) > (clobber (scratch:DI)) > ]) "pr102239.c":3:6 210 {*anddi3_2insn_dot} > (expr_list:REG_DEAD (reg:DI 123) > (nil))) > (jump_insn 10 9 11 2 (set (pc) > (if_then_else (eq (reg:CC 122) > (const_int 0 [0])) > (label_ref 15) > (pc))) "pr102239.c":3:6 868 {*cbranch} > (expr_list:REG_DEAD (reg:CC 122) > (int_list:REG_BR_PROB 536870916 (nil))) > > > > Then in pr102239.c.302r.split2, it is split by "*and<mode>3_2insn_dot" to > rotldi3_mask+lshrdi3_dot: > > Splitting with gen_split_80 (rs6000.md:3721) > > (insn 32 8 33 2 (set (reg:DI 3 3 [124]) > (and:DI (ashift:DI (reg:DI 3 3 [123]) > (const_int 29 [0x1d])) > (const_int -4611686018427387904 [0xc000000000000000]))) > "pr102239.c":3:6 236 {*rotldi3_mask} > (nil)) > (insn 33 32 10 2 (parallel [ > (set (reg:CC 100 0 [122]) > (compare:CC (lshiftrt:DI (reg:DI 3 3 [124]) > (const_int 29 [0x1d])) > (const_int 0 [0]))) > (clobber (reg:DI 3 3 [124])) > ]) "pr102239.c":3:6 281 {*lshrdi3_dot} > (nil)) > > > Why this difference happens? What difference? It is split by the same pattern that matched it, and that is the 2insn pattern. I'm not sure what problem you see? > 0x600000000 is not a valid mask for anddi3_2insn_dot: It should be though! > "(<MODE>mode == Pmode || UINTVAL (operands[2]) <= 0x7fffffff) > && rs6000_is_valid_2insn_and (operands[2], <MODE>mode) > && !(rs6000_is_valid_and_mask (operands[2], <MODE>mode) > || logical_const_operand (operands[2], <MODE>mode))" > > > (gdb) p UINTVAL (operands[2]) <= 0x7fffffff > $84 = false But we have Pmode here so all is fine. > (gdb) p rs6000_is_valid_2insn_and (operands[2], E_DImode) > $85 = true > (gdb) p logical_const_operand (operands[2], E_DImode) > $86 = false > (gdb) p rs6000_is_valid_and_mask (operands[2], E_DImode) > $87 = false > (gdb) p Pmode > $88 = DImode Yes, and <MODE>mode is DImode as well. My point is that we do not have any pattern that can recognise this that will end up as just one machine insn. anddi3_2insn_dot split to two machine insns, and it should: its name indicates we want that!
next prev parent reply other threads:[~2021-11-24 23:22 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-08 11:55 [Bug c/102239] New: " npiggin at gmail dot com 2021-09-09 19:40 ` [Bug target/102239] " segher at gcc dot gnu.org 2021-11-24 7:17 ` luoxhu at gcc dot gnu.org 2021-11-24 23:22 ` segher at gcc dot gnu.org [this message] 2021-11-26 8:50 ` luoxhu at gcc dot gnu.org 2021-11-26 15:53 ` segher at gcc dot gnu.org 2021-11-29 3:31 ` luoxhu at gcc dot gnu.org 2021-11-29 6:36 ` luoxhu at gcc dot gnu.org 2021-11-29 10:05 ` segher at gcc dot gnu.org 2021-11-30 5:28 ` luoxhu at gcc dot gnu.org 2021-11-30 22:59 ` segher at gcc dot gnu.org 2021-12-01 7:46 ` luoxhu at gcc dot gnu.org 2022-01-11 9:23 ` cvs-commit at gcc dot gnu.org 2022-01-12 0:27 ` luoxhu at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102239-4-Al77nCg8Od@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).