public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "segher at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/102239] powerpc suboptimal boolean test of contiguous bits Date: Tue, 30 Nov 2021 22:59:10 +0000 [thread overview] Message-ID: <bug-102239-4-OwP5HMuawa@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102239-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102239 --- Comment #10 from Segher Boessenkool <segher at gcc dot gnu.org> --- (In reply to luoxhu from comment #9) > > It does matter, if what you are want to see is if it is smaller than zero or > > greater than zero. CCmode includes those things. There is a CCEQmode for > > if only the EQ bit is set correctly. > > Got it, thanks. As the example in c#7. If CCmode is LT, rotate data to > highest bits will get negative result and set CR0 to negative, which is > unexpected. CCmode is all three (or four, for non-fast FP) comparison results at once. You can use for example both LT and EQ on the same result. In CCEQmode only the EQ bit is valid. > > Some pattern that just does this as an rldicr, as a single insn. It will > > have to be excluded by the 2insn thing (it is only a single insn itself!), > > and it will have to have comparison mode CCEQ only. > > I was motivated by the clang code, and tried to rotate the data to LSB > instead, it doesn't suffer from CCmode issue again? Will this be simpler > than the combine & new pattern solution? It is incorrect, in a similar way. It also is sub-optimal, it is better to tell GCC that this pattern will be only one machine insn, so that it can consider that when choosing the best insn patterns to use. Also note the comment right before this code: /* If it is one stretch of ones, it is DImode; shift left, mask, then shift right. This generates better code than doing the masks without shifts, or shifting first right and then left. */
next prev parent reply other threads:[~2021-11-30 22:59 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-08 11:55 [Bug c/102239] New: " npiggin at gmail dot com 2021-09-09 19:40 ` [Bug target/102239] " segher at gcc dot gnu.org 2021-11-24 7:17 ` luoxhu at gcc dot gnu.org 2021-11-24 23:22 ` segher at gcc dot gnu.org 2021-11-26 8:50 ` luoxhu at gcc dot gnu.org 2021-11-26 15:53 ` segher at gcc dot gnu.org 2021-11-29 3:31 ` luoxhu at gcc dot gnu.org 2021-11-29 6:36 ` luoxhu at gcc dot gnu.org 2021-11-29 10:05 ` segher at gcc dot gnu.org 2021-11-30 5:28 ` luoxhu at gcc dot gnu.org 2021-11-30 22:59 ` segher at gcc dot gnu.org [this message] 2021-12-01 7:46 ` luoxhu at gcc dot gnu.org 2022-01-11 9:23 ` cvs-commit at gcc dot gnu.org 2022-01-12 0:27 ` luoxhu at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102239-4-OwP5HMuawa@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).