public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "qinzhao at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/102285] New flag -ftrivial-auto-var-init=zero causes crash in pr82421.c Date: Mon, 04 Oct 2021 20:34:02 +0000 [thread overview] Message-ID: <bug-102285-4-ZTg1Mmgm4g@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102285-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102285 --- Comment #26 from qinzhao at gcc dot gnu.org --- (In reply to qinzhao from comment #25) > (In reply to Richard Biener from comment #22) > > Hmm, my proposed patch seems to work. I've adjusted it to not regress > > previously correctly handled cases and will test it fully. > > I guess the reason for it worked for you because you tested it after the > patch for 102587? > > --- a/gcc/internal-fn.c > +++ b/gcc/internal-fn.c > @@ -3035,7 +3035,8 @@ expand_DEFERRED_INIT (internal_fn, gcall *stmt) > /* Expand this memset call. */ > expand_builtin_memset (m_call, NULL_RTX, TYPE_MODE (var_type)); > } > - else > + /* ??? Deal with poly-int sized registers. */ > + else if (tree_fits_uhwi_p (TYPE_SIZE_UNIT (var_type))) > { > /* If this variable is in a register, use expand_assignment might > generate better code. */ because for the following IR: MEM[(int[0:D.1993] *)&fb.3] = .DEFERRED_INIT (16, 2, 1); The "var_type" of the LHS is "int[0:D.1993]", which is not an integer constant (even though the type for fb.3 should be the new type for the new temporary variable char[16]). As a result, the new added check > + /* ??? Deal with poly-int sized registers. */ > + else if (tree_fits_uhwi_p (TYPE_SIZE_UNIT (var_type))) excluded it from expanding through expand_assign.
next prev parent reply other threads:[~2021-10-04 20:34 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-10 21:50 [Bug c/102285] New: New flag -ftrivial-auto-var-init=zero causes many crashes in the testsuite dcb314 at hotmail dot com 2021-09-10 22:11 ` [Bug middle-end/102285] " qinzhao at gcc dot gnu.org 2021-09-10 22:28 ` qinzhao at gcc dot gnu.org 2021-09-10 22:34 ` pinskia at gcc dot gnu.org 2021-09-10 23:10 ` qing.zhao at oracle dot com 2021-09-12 3:33 ` qinzhao at gcc dot gnu.org 2021-09-12 8:06 ` dcb314 at hotmail dot com 2021-09-13 10:25 ` rguenth at gcc dot gnu.org 2021-09-13 17:30 ` qinzhao at gcc dot gnu.org 2021-09-29 22:44 ` [Bug middle-end/102285] New flag -ftrivial-auto-var-init=zero causes crash in pr82421.c qinzhao at gcc dot gnu.org 2021-09-30 19:30 ` qinzhao at gcc dot gnu.org 2021-09-30 20:22 ` qinzhao at gcc dot gnu.org 2021-09-30 20:53 ` dcb314 at hotmail dot com 2021-09-30 22:09 ` qinzhao at gcc dot gnu.org 2021-10-01 6:51 ` rguenth at gcc dot gnu.org 2021-10-01 9:45 ` egallager at gcc dot gnu.org 2021-10-01 16:16 ` qinzhao at gcc dot gnu.org 2021-10-01 16:43 ` qing.zhao at oracle dot com 2021-10-01 20:09 ` qinzhao at gcc dot gnu.org 2021-10-01 20:23 ` qinzhao at gcc dot gnu.org 2021-10-04 6:27 ` rguenther at suse dot de 2021-10-04 6:29 ` rguenther at suse dot de 2021-10-04 9:10 ` rguenth at gcc dot gnu.org 2021-10-04 9:30 ` rguenth at gcc dot gnu.org 2021-10-04 11:53 ` rguenth at gcc dot gnu.org 2021-10-04 14:54 ` rguenth at gcc dot gnu.org 2021-10-04 17:16 ` qinzhao at gcc dot gnu.org 2021-10-04 20:34 ` qinzhao at gcc dot gnu.org [this message] 2021-10-04 20:59 ` qinzhao at gcc dot gnu.org 2021-10-04 21:44 ` qinzhao at gcc dot gnu.org 2021-10-05 8:36 ` cvs-commit at gcc dot gnu.org 2021-10-05 8:47 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102285-4-ZTg1Mmgm4g@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).