public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "egallager at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/102285] New flag -ftrivial-auto-var-init=zero causes crash in pr82421.c
Date: Fri, 01 Oct 2021 09:45:53 +0000	[thread overview]
Message-ID: <bug-102285-4-vnUXcdGFAd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102285-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102285

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org,
                   |                            |egallager at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org,
                   |                            |vries at gcc dot gnu.org
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=82421

--- Comment #14 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to David Binderman from comment #11)
> (In reply to qinzhao from comment #10)
> 
> > 2734         /* The heuristic of fold_builtin_alloca_with_align differs
> 
> git blame says:
> 
> 
> 13e49da934e9 (Tom de Vries           2011-10-07 12:49:49 +0000 2732)        
> /* The heuristic of fold_builtin_alloca_with_align differs before and
> 13e49da934e9 (Tom de Vries           2011-10-07 12:49:49 +0000 2733)      
> after inlining, so we don't require the arg to be changed into a
> 13e49da934e9 (Tom de Vries           2011-10-07 12:49:49 +0000 2734)      
> constant for folding, but just to be constant.  */
> 9e878cf1bae7 (Eric Botcazou          2017-10-19 15:58:05 +0000 2735)        
> if (gimple_call_builtin_p (stmt, BUILT_IN_ALLOCA_WITH_ALIGN)
> 9e878cf1bae7 (Eric Botcazou          2017-10-19 15:58:05 +0000 2736)       
> || gimple_call_builtin_p (stmt, BUILT_IN_ALLOCA_WITH_ALIGN_AND_MAX))
> 1fed1006552c (Tom de Vries           2011-08-31 07:04:25 +0000 2737)        
> {
> 13e49da934e9 (Tom de Vries           2011-10-07 12:49:49 +0000 2738)        
> tree new_rhs = fold_builtin_alloca_with_align (stmt);
> 5d882cc1dafe (Richard Guenther       2011-09-02 11:53:55 +0000 2739)        
> if (new_rhs)
> 5d882cc1dafe (Richard Guenther       2011-09-02 11:53:55 +0000 2740)        
> {
> 52a5515ed661 (Richard Biener         2021-04-14 13:40:58 +0200 2741)       
> gimplify_and_update_call_from_tree (gsi, new_rhs);
> 2f31f742a693 (Tom de Vries           2011-12-17 11:39:43 +0000 2742)       
> tree var = TREE_OPERAND (TREE_OPERAND (new_rhs, 0),0);
> 2f31f742a693 (Tom de Vries           2011-12-17 11:39:43 +0000 2743)       
> insert_clobbers_for_var (*gsi, var);
> 5d882cc1dafe (Richard Guenther       2011-09-02 11:53:55 +0000 2744)       
> return true;
> 5d882cc1dafe (Richard Guenther       2011-09-02 11:53:55 +0000 2745)        
> }
> 1fed1006552c (Tom de Vries           2011-08-31 07:04:25 +0000 2746)        
> }
> 
> so at least Tom, Eric and Richard have been in there.

cc-ing them

  parent reply	other threads:[~2021-10-01  9:45 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 21:50 [Bug c/102285] New: New flag -ftrivial-auto-var-init=zero causes many crashes in the testsuite dcb314 at hotmail dot com
2021-09-10 22:11 ` [Bug middle-end/102285] " qinzhao at gcc dot gnu.org
2021-09-10 22:28 ` qinzhao at gcc dot gnu.org
2021-09-10 22:34 ` pinskia at gcc dot gnu.org
2021-09-10 23:10 ` qing.zhao at oracle dot com
2021-09-12  3:33 ` qinzhao at gcc dot gnu.org
2021-09-12  8:06 ` dcb314 at hotmail dot com
2021-09-13 10:25 ` rguenth at gcc dot gnu.org
2021-09-13 17:30 ` qinzhao at gcc dot gnu.org
2021-09-29 22:44 ` [Bug middle-end/102285] New flag -ftrivial-auto-var-init=zero causes crash in pr82421.c qinzhao at gcc dot gnu.org
2021-09-30 19:30 ` qinzhao at gcc dot gnu.org
2021-09-30 20:22 ` qinzhao at gcc dot gnu.org
2021-09-30 20:53 ` dcb314 at hotmail dot com
2021-09-30 22:09 ` qinzhao at gcc dot gnu.org
2021-10-01  6:51 ` rguenth at gcc dot gnu.org
2021-10-01  9:45 ` egallager at gcc dot gnu.org [this message]
2021-10-01 16:16 ` qinzhao at gcc dot gnu.org
2021-10-01 16:43 ` qing.zhao at oracle dot com
2021-10-01 20:09 ` qinzhao at gcc dot gnu.org
2021-10-01 20:23 ` qinzhao at gcc dot gnu.org
2021-10-04  6:27 ` rguenther at suse dot de
2021-10-04  6:29 ` rguenther at suse dot de
2021-10-04  9:10 ` rguenth at gcc dot gnu.org
2021-10-04  9:30 ` rguenth at gcc dot gnu.org
2021-10-04 11:53 ` rguenth at gcc dot gnu.org
2021-10-04 14:54 ` rguenth at gcc dot gnu.org
2021-10-04 17:16 ` qinzhao at gcc dot gnu.org
2021-10-04 20:34 ` qinzhao at gcc dot gnu.org
2021-10-04 20:59 ` qinzhao at gcc dot gnu.org
2021-10-04 21:44 ` qinzhao at gcc dot gnu.org
2021-10-05  8:36 ` cvs-commit at gcc dot gnu.org
2021-10-05  8:47 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102285-4-vnUXcdGFAd@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).