public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "qinzhao at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/102285] New flag -ftrivial-auto-var-init=zero causes crash in pr82421.c
Date: Thu, 30 Sep 2021 22:09:13 +0000	[thread overview]
Message-ID: <bug-102285-4-vP8LqgPV69@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102285-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102285

--- Comment #12 from qinzhao at gcc dot gnu.org ---
with the following change, I can resolve the ICE:

[opc@qinzhao-ol8u3-x86 gcc]$ git diff
diff --git a/gcc/tree-ssa-ccp.c b/gcc/tree-ssa-ccp.c
index 70ce6a4d5b8d..b07026165075 100644
--- a/gcc/tree-ssa-ccp.c
+++ b/gcc/tree-ssa-ccp.c
@@ -2655,6 +2655,7 @@ fold_builtin_alloca_with_align (gimple *stmt)
     SET_DECL_PT_UID (var, uid);

   /* Fold alloca to the address of the array.  */
+  mark_addressable (var);
   return fold_convert (TREE_TYPE (lhs), build_fold_addr_expr (var));
 }

diff --git a/gcc/tree-ssa.c b/gcc/tree-ssa.c
index 0fba404babe9..e06609861bf1 100644
--- a/gcc/tree-ssa.c
+++ b/gcc/tree-ssa.c
@@ -1657,7 +1657,7 @@ maybe_optimize_var (tree var, bitmap addresses_taken,
bitmap not_reg_needs,
   bool maybe_reg = false;
   if (TREE_ADDRESSABLE (var))
     {
-      TREE_ADDRESSABLE (var) = 0;
+      //TREE_ADDRESSABLE (var) = 0;
       maybe_reg = true;
       if (dump_file)
        {


However, I am not very sure the change in tree-ssa.c. why TREE_ADDRESSABLE
(var) is reverted in this routine?

  parent reply	other threads:[~2021-09-30 22:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 21:50 [Bug c/102285] New: New flag -ftrivial-auto-var-init=zero causes many crashes in the testsuite dcb314 at hotmail dot com
2021-09-10 22:11 ` [Bug middle-end/102285] " qinzhao at gcc dot gnu.org
2021-09-10 22:28 ` qinzhao at gcc dot gnu.org
2021-09-10 22:34 ` pinskia at gcc dot gnu.org
2021-09-10 23:10 ` qing.zhao at oracle dot com
2021-09-12  3:33 ` qinzhao at gcc dot gnu.org
2021-09-12  8:06 ` dcb314 at hotmail dot com
2021-09-13 10:25 ` rguenth at gcc dot gnu.org
2021-09-13 17:30 ` qinzhao at gcc dot gnu.org
2021-09-29 22:44 ` [Bug middle-end/102285] New flag -ftrivial-auto-var-init=zero causes crash in pr82421.c qinzhao at gcc dot gnu.org
2021-09-30 19:30 ` qinzhao at gcc dot gnu.org
2021-09-30 20:22 ` qinzhao at gcc dot gnu.org
2021-09-30 20:53 ` dcb314 at hotmail dot com
2021-09-30 22:09 ` qinzhao at gcc dot gnu.org [this message]
2021-10-01  6:51 ` rguenth at gcc dot gnu.org
2021-10-01  9:45 ` egallager at gcc dot gnu.org
2021-10-01 16:16 ` qinzhao at gcc dot gnu.org
2021-10-01 16:43 ` qing.zhao at oracle dot com
2021-10-01 20:09 ` qinzhao at gcc dot gnu.org
2021-10-01 20:23 ` qinzhao at gcc dot gnu.org
2021-10-04  6:27 ` rguenther at suse dot de
2021-10-04  6:29 ` rguenther at suse dot de
2021-10-04  9:10 ` rguenth at gcc dot gnu.org
2021-10-04  9:30 ` rguenth at gcc dot gnu.org
2021-10-04 11:53 ` rguenth at gcc dot gnu.org
2021-10-04 14:54 ` rguenth at gcc dot gnu.org
2021-10-04 17:16 ` qinzhao at gcc dot gnu.org
2021-10-04 20:34 ` qinzhao at gcc dot gnu.org
2021-10-04 20:59 ` qinzhao at gcc dot gnu.org
2021-10-04 21:44 ` qinzhao at gcc dot gnu.org
2021-10-05  8:36 ` cvs-commit at gcc dot gnu.org
2021-10-05  8:47 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102285-4-vP8LqgPV69@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).