public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102586] [12 Regression] ICE in clear_padding_type, at gimple-fold.c:4798 since r12-3433-ga25e0b5e6ac8a77a
Date: Thu, 07 Apr 2022 07:15:13 +0000	[thread overview]
Message-ID: <bug-102586-4-ZIAhqQBWKO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102586-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102586

--- Comment #30 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:46c739d40c6c1028295931c53cf414d581519072

commit r12-8042-g46c739d40c6c1028295931c53cf414d581519072
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Apr 7 09:14:07 2022 +0200

    c++: Handle __builtin_clear_padding on non-trivially-copyable types
[PR102586]

    On Fri, Feb 11, 2022 at 07:55:50PM +0100, Jakub Jelinek via Gcc-patches
wrote:
    > Something like the
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102586#c16
    > will still be needed with adjusted testcase from
    > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102586#c15 such that
    > __builtin_clear_padding is called directly on var addresses rather than
    > in separate functions.

    Here is an updated version of the
    https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102586#c15
    patch which uses FIELD_DECL in the langhook instead of its TREE_TYPE,
    and the testcases have been adjusted for the builtin accepting
    pointers to non-trivially-copyable types only if it is address of a
    declaration.

    2022-04-07  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/102586
    gcc/
            * langhooks.h (struct lang_hooks_for_types): Add classtype_as_base
            langhook.
            * langhooks-def.h (LANG_HOOKS_CLASSTYPE_AS_BASE): Define.
            (LANG_HOOKS_FOR_TYPES_INITIALIZER): Add it.
            * gimple-fold.cc (clear_padding_type): Use ftype instead of
            TREE_TYPE (field) some more.  For artificial FIELD_DECLs without
            name try the lang_hooks.types.classtype_as_base langhook and
            if it returns non-NULL, use that instead of ftype for recursive
call.
    gcc/cp/
            * cp-objcp-common.h (cp_classtype_as_base): Declare.
            (LANG_HOOKS_CLASSTYPE_AS_BASE): Redefine.
            * cp-objcp-common.cc (cp_classtype_as_base): New function.
    gcc/testsuite/
            * g++.dg/torture/builtin-clear-padding-5.C: New test.
            * g++.dg/cpp2a/builtin-clear-padding1.C (bar): Uncomment one
            call that is now accepted.

  parent reply	other threads:[~2022-04-07  7:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04  7:30 [Bug tree-optimization/102586] New: " marxin at gcc dot gnu.org
2021-10-04  7:30 ` [Bug tree-optimization/102586] " marxin at gcc dot gnu.org
2021-10-04  8:21 ` jakub at gcc dot gnu.org
2021-10-04  8:22 ` marxin at gcc dot gnu.org
2021-10-04 11:43 ` jakub at gcc dot gnu.org
2021-10-04 12:04 ` jakub at gcc dot gnu.org
2021-11-15 13:03 ` jakub at gcc dot gnu.org
2021-11-15 13:05 ` jakub at gcc dot gnu.org
2022-01-17 13:14 ` rguenth at gcc dot gnu.org
2022-02-09 17:21 ` jason at gcc dot gnu.org
2022-02-10 14:08 ` jakub at gcc dot gnu.org
2022-02-10 14:18 ` jakub at gcc dot gnu.org
2022-02-10 15:29 ` jakub at gcc dot gnu.org
2022-02-10 15:35 ` jakub at gcc dot gnu.org
2022-02-10 15:56 ` jason at gcc dot gnu.org
2022-02-10 18:30 ` jakub at gcc dot gnu.org
2022-02-10 18:45 ` jason at gcc dot gnu.org
2022-02-10 19:27 ` jakub at gcc dot gnu.org
2022-02-10 22:07 ` jason at gcc dot gnu.org
2022-02-10 22:27 ` jakub at gcc dot gnu.org
2022-02-10 22:29 ` jakub at gcc dot gnu.org
2022-02-10 22:34 ` jakub at gcc dot gnu.org
2022-02-11  1:47 ` rodgertq at gcc dot gnu.org
2022-02-11 12:31 ` jakub at gcc dot gnu.org
2022-02-11 15:29 ` jason at gcc dot gnu.org
2022-02-11 16:23 ` qing.zhao at oracle dot com
2022-02-11 16:39 ` jakub at gcc dot gnu.org
2022-02-11 17:36 ` qinzhao at gcc dot gnu.org
2022-02-11 17:47 ` jakub at gcc dot gnu.org
2022-02-11 21:52 ` qing.zhao at oracle dot com
2022-03-12  4:40 ` jason at gcc dot gnu.org
2022-03-14  9:49 ` cvs-commit at gcc dot gnu.org
2022-04-07  7:15 ` cvs-commit at gcc dot gnu.org [this message]
2022-04-07  7:19 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102586-4-ZIAhqQBWKO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).