public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jason at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/102586] [12 Regression] ICE in clear_padding_type, at gimple-fold.c:4798 since r12-3433-ga25e0b5e6ac8a77a Date: Thu, 10 Feb 2022 22:07:40 +0000 [thread overview] Message-ID: <bug-102586-4-wOPobcgON1@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102586-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102586 --- Comment #16 from Jason Merrill <jason at gcc dot gnu.org> --- Created attachment 52410 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52410&action=edit sketch of vbase handling This is roughly what I had in mind, though it's algorithmically poor because it walks all the bases each time. But then it occurred to me that unless we know the complete object type, we don't know whether we're dealing with a base subobject, and risk clearing too much: struct C1 { virtual void f() {} char d; }; // vfn to make non-layout-POD struct C2: C1 { char c; }; __attribute__((noipa)) void foo (C1 *q) { __builtin_clear_padding (q); } int main() { C2 c2; c2.c = 42; foo (&c2); if (c2.c != 42) __builtin_abort(); } Because of this, I think we probably want __builtin_clear_padding to reject arguments that point to non-trivially-copyable type. And then we don't need to worry about vbases.
next prev parent reply other threads:[~2022-02-10 22:07 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-04 7:30 [Bug tree-optimization/102586] New: " marxin at gcc dot gnu.org 2021-10-04 7:30 ` [Bug tree-optimization/102586] " marxin at gcc dot gnu.org 2021-10-04 8:21 ` jakub at gcc dot gnu.org 2021-10-04 8:22 ` marxin at gcc dot gnu.org 2021-10-04 11:43 ` jakub at gcc dot gnu.org 2021-10-04 12:04 ` jakub at gcc dot gnu.org 2021-11-15 13:03 ` jakub at gcc dot gnu.org 2021-11-15 13:05 ` jakub at gcc dot gnu.org 2022-01-17 13:14 ` rguenth at gcc dot gnu.org 2022-02-09 17:21 ` jason at gcc dot gnu.org 2022-02-10 14:08 ` jakub at gcc dot gnu.org 2022-02-10 14:18 ` jakub at gcc dot gnu.org 2022-02-10 15:29 ` jakub at gcc dot gnu.org 2022-02-10 15:35 ` jakub at gcc dot gnu.org 2022-02-10 15:56 ` jason at gcc dot gnu.org 2022-02-10 18:30 ` jakub at gcc dot gnu.org 2022-02-10 18:45 ` jason at gcc dot gnu.org 2022-02-10 19:27 ` jakub at gcc dot gnu.org 2022-02-10 22:07 ` jason at gcc dot gnu.org [this message] 2022-02-10 22:27 ` jakub at gcc dot gnu.org 2022-02-10 22:29 ` jakub at gcc dot gnu.org 2022-02-10 22:34 ` jakub at gcc dot gnu.org 2022-02-11 1:47 ` rodgertq at gcc dot gnu.org 2022-02-11 12:31 ` jakub at gcc dot gnu.org 2022-02-11 15:29 ` jason at gcc dot gnu.org 2022-02-11 16:23 ` qing.zhao at oracle dot com 2022-02-11 16:39 ` jakub at gcc dot gnu.org 2022-02-11 17:36 ` qinzhao at gcc dot gnu.org 2022-02-11 17:47 ` jakub at gcc dot gnu.org 2022-02-11 21:52 ` qing.zhao at oracle dot com 2022-03-12 4:40 ` jason at gcc dot gnu.org 2022-03-14 9:49 ` cvs-commit at gcc dot gnu.org 2022-04-07 7:15 ` cvs-commit at gcc dot gnu.org 2022-04-07 7:19 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102586-4-wOPobcgON1@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).