public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/103226] [12 Regression] Recent change to copy-headers causes execution failure for gcc.dg/torture/pr80974
Date: Sat, 20 Nov 2021 16:30:22 +0000	[thread overview]
Message-ID: <bug-103226-4-3toPE07vB6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103226-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103226

--- Comment #22 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jeff Law <law@gcc.gnu.org>:

https://gcc.gnu.org/g:7950c96ca667ddaab9d6e894da3958ebc2e2dccb

commit r12-5432-g7950c96ca667ddaab9d6e894da3958ebc2e2dccb
Author: Jeff Law <jeffreyalaw@gmail.com>
Date:   Sat Nov 20 11:20:07 2021 -0500

    Clobber the condition code in the bfin doloop patterns

    Per Aldy's excellent, but tough to follow analysis in PR 103226, this patch
    fixes the bfin-elf regression.

    In simplest terms the doloop patterns on this port may clobber the
condition
    code register, but they do not expose that until after register allocation.
    That would be fine, except that other patterns have exposed CC earlier.  As
    a result the dataflow, particularly for CC, is incorrect.

    This leads the register allocators to assume that a value in CC outside the
    loop is still valid inside the loop when in fact, the value has been
    clobbered.  This is what caused pr80974 to start failing.

    With this fix, not only do we fix the pr80974 regression, but we fix ~20
    other execution failures in the port.  It also reduces test time for the
    port from ~90 minutes to ~60 minutes.

            PR tree-optimization/103226
    gcc/
            * config/bfin/bfin.md (doloop pattern, splitter and expander):
Clobber
            CC.

  parent reply	other threads:[~2021-11-20 16:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13 20:39 [Bug tree-optimization/103226] New: " law at gcc dot gnu.org
2021-11-14 10:59 ` [Bug tree-optimization/103226] " aldyh at gcc dot gnu.org
2021-11-15  9:03 ` rguenth at gcc dot gnu.org
2021-11-16  2:30 ` law at gcc dot gnu.org
2021-11-17 11:14 ` aldyh at gcc dot gnu.org
2021-11-17 11:32 ` aldyh at gcc dot gnu.org
2021-11-17 15:00 ` tnfchris at gcc dot gnu.org
2021-11-17 15:02 ` tnfchris at gcc dot gnu.org
2021-11-17 15:53 ` aldyh at gcc dot gnu.org
2021-11-17 16:09 ` tnfchris at gcc dot gnu.org
2021-11-17 16:28 ` law at gcc dot gnu.org
2021-11-17 16:29 ` law at gcc dot gnu.org
2021-11-17 16:31 ` aldyh at gcc dot gnu.org
2021-11-17 17:18 ` aldyh at gcc dot gnu.org
2021-11-17 17:54 ` tnfchris at gcc dot gnu.org
2021-11-17 18:31 ` law at gcc dot gnu.org
2021-11-17 18:43 ` aldyh at gcc dot gnu.org
2021-11-17 19:26 ` aldyh at gcc dot gnu.org
2021-11-17 20:02 ` aldyh at gcc dot gnu.org
2021-11-18 13:28 ` aldyh at gcc dot gnu.org
2021-11-20  7:10 ` law at gcc dot gnu.org
2021-11-20  7:23 ` aldyh at gcc dot gnu.org
2021-11-20 16:30 ` cvs-commit at gcc dot gnu.org [this message]
2021-11-20 16:31 ` law at gcc dot gnu.org
2021-12-02 14:55 ` hp at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103226-4-3toPE07vB6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).