public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ebotcazou at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug driver/103465] [12 regression] -freorder-blocks-and-partition broken on 64-bit Windows
Date: Thu, 06 Jan 2022 11:42:59 +0000 [thread overview]
Message-ID: <bug-103465-4-kyRMOn6mOu@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103465-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103465
--- Comment #20 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> Can you be more concrete about what's wrong with that? I haven't changed the
> conditions that drop the flag, but only make it respect pragmas.
Previously the opts.c logic would trigger only with the pragma, now it triggers
even without it, disabling flag_reorder_blocks_and_partition in all cases:
/* If user requested unwind info, then turn off the partitioning
optimization. */
if (opts->x_flag_unwind_tables
&& !targetm_common.unwind_tables_default
&& opts->x_flag_reorder_blocks_and_partition
&& (ui_except == UI_SJLJ || ui_except >= UI_TARGET))
{
if (opts_set->x_flag_reorder_blocks_and_partition)
inform (loc,
"%<-freorder-blocks-and-partition%> does not support "
"unwind info on this architecture");
opts->x_flag_reorder_blocks_and_partition = 0;
opts->x_flag_reorder_blocks = 1;
}
/* If the target requested unwind info, then turn off the partitioning
optimization with a different message. Likewise, if the target does not
support named sections. */
if (opts->x_flag_reorder_blocks_and_partition
&& (!targetm_common.have_named_sections
|| (opts->x_flag_unwind_tables
&& targetm_common.unwind_tables_default
&& (ui_except == UI_SJLJ || ui_except >= UI_TARGET))))
{
if (opts_set->x_flag_reorder_blocks_and_partition)
inform (loc,
"%<-freorder-blocks-and-partition%> does not work "
"on this architecture");
opts->x_flag_reorder_blocks_and_partition = 0;
opts->x_flag_reorder_blocks = 1;
}
I guess that we need to define TARGET_UNWIND_TABLES_DEFAULT for 64-bit Windows
but that would probably only generate the second error instead of the first,
and we need none since -freorder-blocks-and-partition works fine there.
next prev parent reply other threads:[~2022-01-06 11:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 10:00 [Bug rtl-optimization/103465] New: Invalid note with -fno-reorder-blocks-and-partition tomas.kalibera at gmail dot com
2021-11-29 10:12 ` [Bug rtl-optimization/103465] " marxin at gcc dot gnu.org
2021-11-29 10:17 ` tomas.kalibera at gmail dot com
2021-11-29 10:18 ` marxin at gcc dot gnu.org
2021-11-29 13:23 ` marxin at gcc dot gnu.org
2021-11-29 15:25 ` tomas.kalibera at gmail dot com
2021-12-09 13:39 ` marxin at gcc dot gnu.org
2021-12-09 13:40 ` marxin at gcc dot gnu.org
2021-12-09 14:37 ` tomas.kalibera at gmail dot com
2021-12-09 14:41 ` tomas.kalibera at gmail dot com
2021-12-09 14:44 ` tomas.kalibera at gmail dot com
2021-12-09 15:24 ` tomas.kalibera at gmail dot com
2021-12-09 15:28 ` marxin at gcc dot gnu.org
2021-12-09 15:44 ` marxin at gcc dot gnu.org
2021-12-09 15:53 ` tomas.kalibera at gmail dot com
2021-12-09 15:55 ` tomas.kalibera at gmail dot com
2021-12-09 19:29 ` marxin at gcc dot gnu.org
2021-12-28 10:05 ` [Bug driver/103465] " cvs-commit at gcc dot gnu.org
2021-12-28 10:06 ` marxin at gcc dot gnu.org
2022-01-06 7:32 ` [Bug driver/103465] [12 regression] -freorder-blocks-and-partition broken on 64-bit Windows ebotcazou at gcc dot gnu.org
2022-01-06 9:51 ` marxin at gcc dot gnu.org
2022-01-06 11:42 ` ebotcazou at gcc dot gnu.org [this message]
2022-01-06 12:47 ` marxin at gcc dot gnu.org
2022-01-06 13:45 ` ebotcazou at gcc dot gnu.org
2022-01-06 13:50 ` marxin at gcc dot gnu.org
2022-01-06 14:07 ` tomas.kalibera at gmail dot com
2022-01-06 17:17 ` [Bug target/103465] " ebotcazou at gcc dot gnu.org
2022-01-06 22:18 ` tomas.kalibera at gmail dot com
2022-01-07 9:50 ` tomas.kalibera at gmail dot com
2022-01-07 17:33 ` tomas.kalibera at gmail dot com
2022-01-10 11:44 ` cvs-commit at gcc dot gnu.org
2022-01-10 16:06 ` cvs-commit at gcc dot gnu.org
2022-01-10 16:06 ` cvs-commit at gcc dot gnu.org
2022-01-10 16:07 ` cvs-commit at gcc dot gnu.org
2022-01-10 16:09 ` ebotcazou at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-103465-4-kyRMOn6mOu@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).