public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tomas.kalibera at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/103465] Invalid note with -fno-reorder-blocks-and-partition
Date: Thu, 09 Dec 2021 15:24:58 +0000	[thread overview]
Message-ID: <bug-103465-4-l1w2AryI9I@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-103465-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103465

--- Comment #10 from Tomas Kalibera <tomas.kalibera at gmail dot com> ---
(In reply to Tomas Kalibera from comment #7)
> (In reply to Martin Liška from comment #5)
> > > However, still talking about the current master only, I see a difference
> > > with -O3, when I try on the repro example from Bug 103274 and -O3:
> > > 
> > > x86_64-w64-mingw32-gcc -c -S -O3 -fno-reorder-blocks-and-partition a.c -o
> > > nropt.s
> > > 
> > > x86_64-w64-mingw32-gcc -c -S -O3 -freorder-blocks-and-partition a.c -o ropt.s
> > > x86_64-w64-mingw32-gcc -c -S -O3  a.c -o noopt.s
> > > 
> > > All of these assembler files are different (and from my non-expert reading,
> > > noopt.s uses the optimization and does have the invalid unwind information
> > > as reported in Bug 103274). Is the optimization correctly dropped also with
> > > -O3 only?
> > 
> > Hmmm, I've just tested the same with the locally built cross-compiler:
> > ~/Programming/gcc/configure --enable-languages=c,c++
> > --prefix=/home/marxin/bin/gcc --disable-multilib --enable-host-shared
> > --disable-libsanitizer --enable-valgrind-annotations --disable-bootstrap
> > --target=x86_64-w64-mingw32
> > 
> > and it works fine, all 3 assembly files are identical.
> 

It tried on the current GCC trunk as now
(747380f47da0da6c11fd5262ac428bb53433ea19). 

ropt.s is still the same as noopt.s. The unwinding information is correct now,
because Bug 103274 has been fixed in the meantime. However, indeed, the
reordering optimization is applied.

nropt.s has correct unwinding information without the reordering.

So, still, the reorder-stacks-and-partition optimization is not dropped by
target (though I am not claiming they should be dropped, I don't know, that's
only what I learned from your response to my original report).

For these results I've only changed the git version in the dockerfile.

  parent reply	other threads:[~2021-12-09 15:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29 10:00 [Bug rtl-optimization/103465] New: " tomas.kalibera at gmail dot com
2021-11-29 10:12 ` [Bug rtl-optimization/103465] " marxin at gcc dot gnu.org
2021-11-29 10:17 ` tomas.kalibera at gmail dot com
2021-11-29 10:18 ` marxin at gcc dot gnu.org
2021-11-29 13:23 ` marxin at gcc dot gnu.org
2021-11-29 15:25 ` tomas.kalibera at gmail dot com
2021-12-09 13:39 ` marxin at gcc dot gnu.org
2021-12-09 13:40 ` marxin at gcc dot gnu.org
2021-12-09 14:37 ` tomas.kalibera at gmail dot com
2021-12-09 14:41 ` tomas.kalibera at gmail dot com
2021-12-09 14:44 ` tomas.kalibera at gmail dot com
2021-12-09 15:24 ` tomas.kalibera at gmail dot com [this message]
2021-12-09 15:28 ` marxin at gcc dot gnu.org
2021-12-09 15:44 ` marxin at gcc dot gnu.org
2021-12-09 15:53 ` tomas.kalibera at gmail dot com
2021-12-09 15:55 ` tomas.kalibera at gmail dot com
2021-12-09 19:29 ` marxin at gcc dot gnu.org
2021-12-28 10:05 ` [Bug driver/103465] " cvs-commit at gcc dot gnu.org
2021-12-28 10:06 ` marxin at gcc dot gnu.org
2022-01-06  7:32 ` [Bug driver/103465] [12 regression] -freorder-blocks-and-partition broken on 64-bit Windows ebotcazou at gcc dot gnu.org
2022-01-06  9:51 ` marxin at gcc dot gnu.org
2022-01-06 11:42 ` ebotcazou at gcc dot gnu.org
2022-01-06 12:47 ` marxin at gcc dot gnu.org
2022-01-06 13:45 ` ebotcazou at gcc dot gnu.org
2022-01-06 13:50 ` marxin at gcc dot gnu.org
2022-01-06 14:07 ` tomas.kalibera at gmail dot com
2022-01-06 17:17 ` [Bug target/103465] " ebotcazou at gcc dot gnu.org
2022-01-06 22:18 ` tomas.kalibera at gmail dot com
2022-01-07  9:50 ` tomas.kalibera at gmail dot com
2022-01-07 17:33 ` tomas.kalibera at gmail dot com
2022-01-10 11:44 ` cvs-commit at gcc dot gnu.org
2022-01-10 16:06 ` cvs-commit at gcc dot gnu.org
2022-01-10 16:06 ` cvs-commit at gcc dot gnu.org
2022-01-10 16:07 ` cvs-commit at gcc dot gnu.org
2022-01-10 16:09 ` ebotcazou at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-103465-4-l1w2AryI9I@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).