[Bug d/103528] New: [12 regression] d21 doesn't build on Solaris

[Bug d/103528] New: [12 regression] d21 doesn't build on Solaris

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

            Bug ID: 103528
           Summary: [12 regression] d21 doesn't build on Solaris
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11

The migration to the DMD-based D frontend badly broke Solaris bootstrap on both
sparc and x86.  I'm always using GCC 9.1.0 as bootstrap compiler.

* Solaris 11.4/x86 configured to use /bin/as:

  stage 1 d21 fails to link:

ld: fatal: library -lgphobos: not found

  No wonder, libphobos is disabled on Solaris/x86 when /bin/as is in use.

* Solaris 11.4/x86 configured to use gas:

  libphobos doesn't build:

/vol/gcc/src/hg/master/local/libphobos/libdruntime/core/internal/gc/impl/conservative/gc.d:3169:47:
error: undefined identifier 'SIG_BLOCK'
 3169 |             auto sigmask_rc = pthread_sigmask(SIG_BLOCK, &new_mask,
&old_mask);
      |           

  SIG_BLOCK is used unconditionally, but defined nowhere.  It should be in
  libphobos/libdruntime/core/sys/posix/signal.d.  I'm use a local patch
  (attached) to fix that.

* Solaris 11.4/sparc configured to use /bin/as:

  cannot compile d21, always like:

d21: error: cannot find source code for runtime library file 'object.d'
d21: note: dmd might not be correctly installed. Run 'dmd -man' for
installation instructions.
d21: note: config file: not found
import path[0] = /vol/gcc/src/hg/master/local/gcc/d

  For one, libphobos isn't enabled on Solaris/SPARC by default, so no include
  files are installed.  On Solaris/x86, I default to a gas-based gcc, so
  includes are installed for the bootstrap compiler.

  Besides, the message about dmd -man is wrong/misleading for gdc.

After that, I rebuilt gcc 9.1.0 with gas and --enable-libphobos to get an
appropriate bootstrap compiler. However

* Solaris 11.4/sparc configured to use gas:

  stage 1 d21 cannot even compile a trivial test program when configuring
  libphobos

configure: error: can't compile D sources!
make[2]: *** [Makefile:26643: configure-stage1-target-libphobos] Error 1

  so the build stops.  I'll report the details separately.

I believe there are several issues here beyond the Solaris problems:

* toplevel configure needs to make certain that the bootstrap gdc can compile
  *and link* some trivial D program.  Letting the build proceed otherwise leads
  to confusing link errors as seen here.  gnat can do away without such a test
  because there are no gnat without libgnat configurations (either you have a
  fully working GNAT or you have none), while the gdc without libphobos 
  situation is quite common in GCC.

* I suspect it's time to do away without disabling libphobos on Solaris with
  /bin/as.  I've now successfully bootstrapped master on Solaris 11.3 and 11.4
  with such a patch with both as and gas and the testresults are mostly the
same.
  Certainly no build failures.

* Likewise, it might be possible to declare Solaris/SPARC as sort of supported
  in libphobos.  The test results are still worse than on Solaris/x86, but not
  fundamentally so.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 51920
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51920&action=edit
libphobos: Enable on Solaris/SPARC or with /bin/as [PR 103528]

Proposed patch to do away with treating as and gas differently in libphobos.
Also enable on Solaris/SPARC.

2021-12-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

        libphobos:
        PR d/103528
        * configure.ac <x86_64-*-solaris2.* | i?86-*-solaris2.*>: Remove
        gas requirement.
        * configure: Regenerate.
        * configure.tgt (sparc*-*-solaris2.11*): Mark supported.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 51921
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51921&action=edit
libphobos: Define SIG_BLOCK etc. on Solaris [PR 103528]

Define SIG_BLOCK and friends on Solaris to unbreak bootstrap.

2021-12-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

        libphobos:
        PR d/103528
        * libdruntime/core/sys/posix/signal.d <Solaris>: Define SIG_BLOCK
        etc.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #3 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
(In reply to Rainer Orth from comment #2)
> Created attachment 51921 [details]
> libphobos: Define SIG_BLOCK etc. on Solaris [PR 103528]
> 
> Define SIG_BLOCK and friends on Solaris to unbreak bootstrap.
> 
> 2021-12-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
> 
> 	libphobos:
> 	PR d/103528
> 	* libdruntime/core/sys/posix/signal.d <Solaris>: Define SIG_BLOCK
> 	etc.

I've seen the SIG_BLOCK fix in upstream very recently, will backport this now.

https://github.com/dlang/druntime/pull/3624

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:9c7d5e8846edb28e5421211ee8eaad93e234de2c

commit r12-5887-g9c7d5e8846edb28e5421211ee8eaad93e234de2c
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Fri Dec 10 03:14:20 2021 +0100

    d: Merge upstream dmd 3982604c5, druntime bc58b1e9, phobos 12329adb6.

    D front-end changes:

        - Import dmd mainline development.
        - Split off enum EXP from enum TOK.
        - Integer promotions now follow C integral promotions by default.
        - Implements __traits(initSymbol).
        - Lowering of array construction has been moved to the dmd
          front-end.
        - Fix segfault in dmd.lexer from unaligned read (PR103529).

    Druntime changes:

        - Import druntime mainline development.
        - Define SIG_BLOCK for Solaris (PR103528).

    Phobos changes:

        - Import phobos mainline development.

    gcc/d/ChangeLog:

            PR d/103529
            * dmd/MERGE: Merge upstream dmd 3982604c5.
            * Make-lang.in (D_FRONTEND_OBJS): Add d/root-optional.o.
            * d-attribs.cc (build_attributes): Update for new front-end
interface.
            * d-codegen.cc (d_build_call): Likewise.
            * d-compiler.cc (Compiler::paintAsType): Likewise.
            * d-lang.cc (d_handle_option): Remove OPT_fpreview_intpromote, add
            handling of OPT_frevert_intpromote.
            * d-port.cc (Port::valcpy): Assert buffer is aligned.
            * d-target.cc (Target::isVectorOpSupported): Update for new
front-end
            interface.
            * decl.cc (layout_class_initializer): Likewise.
            * expr.cc (lvalue_p): Likewise.
            (binop_assignment): Likewise.
            (ExprVisitor::visit): Likewise.
            (ExprVisitor::visit (AssignExp *)): Remove generation of
_d_arrayctor
            and _d_arraysetctor library helpers.
            (ExprVisitor::visit (VarExp *)): Support __traits(initSymbol).
            * intrinsics.cc (expand_intrinsic_rotate): Update for new front-end
            interface.
            * lang.opt (fpreview=intpromote): Remove.
            (frevert=intpromote): New.
            * runtime.def (ARRAYCTOR): Remove.
            (ARRAYSETCTOR): Remove.
            * toir.cc (IRVisitor::visit): Update for new front-end interface.
            * types.cc (layout_aggregate_members): Likewise.
            * dmd/root/optional.d: New file.
            * dmd/root/optional.h: New file.

    libphobos/ChangeLog:

            PR d/103528
            * libdruntime/MERGE: Merge upstream druntime bc58b1e9.
            * libdruntime/Makefile.am (DRUNTIME_DSOURCES_LINUX): Remove
            core/sys/linux/syscalls.d.
            * libdruntime/Makefile.in: Regenerate.
            * src/MERGE: Merge upstream phobos 12329adb6.
            * testsuite/libphobos.config/config.exp: Add test22523.
            * libdruntime/core/sys/linux/syscalls.d: Removed.
            * testsuite/libphobos.config/test22523.d: New test.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #5 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
(In reply to Rainer Orth from comment #0)
> * toplevel configure needs to make certain that the bootstrap gdc can compile
>   *and link* some trivial D program.  Letting the build proceed otherwise
> leads
>   to confusing link errors as seen here.  gnat can do away without such a
> test
>   because there are no gnat without libgnat configurations (either you have a
>   fully working GNAT or you have none), while the gdc without libphobos 
>   situation is quite common in GCC.
I'm on the side-line with that observation though, gdc without libphobos has
been defaulted in configure.tgt more because I lack the means for testing such
a broad amount of targets (such as non-x86 BSDs).  When someone does test it
(powerpc64le-freebsd) the report I get back is usually that it works fine.

Rather gdc without libphobos is more of an exception, because the compiler
heavily depends on it existing anyway, with many high-level features lowered
into calls of core druntime helper functions.  Without a runtime, this severely
limits what you can do in the language to a strict subset (that might as well
be C).

To pick a similar example, is this a bug?  Or can it be explained away with
documentation?
---
checking for long long... yes
checking size of long long... configure: error: in `/work/gcc/build/gcc':
configure: error: cannot compute sizeof (long long)
See `config.log' for more details
make[1]: *** [Makefile:4511: configure-gcc] Error 1
make[1]: Leaving directory '/work/gcc/build'
make: *** [Makefile:985: all] Error 2
---
(config.log)
configure:6450: checking size of long long
configure:6455: g++ -o conftest -g     conftest.cpp  >&5
/usr/bin/ld: cannot find -lstdc++
collect2: error: ld returned 1 exit status
configure:6455: $? = 1
configure: program exited with status 1
---

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #6 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #5 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
> (In reply to Rainer Orth from comment #0)
>> * toplevel configure needs to make certain that the bootstrap gdc can compile
>>   *and link* some trivial D program.  Letting the build proceed otherwise
>> leads
>>   to confusing link errors as seen here.  gnat can do away without such a
>> test
>>   because there are no gnat without libgnat configurations (either you have a
>>   fully working GNAT or you have none), while the gdc without libphobos 
>>   situation is quite common in GCC.
> I'm on the side-line with that observation though, gdc without libphobos has
> been defaulted in configure.tgt more because I lack the means for testing such
> a broad amount of targets (such as non-x86 BSDs).  When someone does test it
> (powerpc64le-freebsd) the report I get back is usually that it works fine.
>
> Rather gdc without libphobos is more of an exception, because the compiler
> heavily depends on it existing anyway, with many high-level features lowered
> into calls of core druntime helper functions.  Without a runtime, this severely
> limits what you can do in the language to a strict subset (that might as well
> be C).

I've never claimed that this configuration is actually useful for D
development use.  However, before the switch to d21 in D, you could
configure gcc with --enable-languages=all even on targets that didn't
support libphobos (either because it just wasn't declared as supported
in configure.tgt or because it wouldn't compile).  The resulting build
would produce gdc and d21 and the gdc.* tests would run only those thats
that can work without libphobos, most of them actually succeeding.

After the switch to the D d21, this no longer works: if you do this on a
target that lacks either gdc or libphobos for any reason, the
--enable-languages=all configuration would succeed, howeve, the stage1
libphobos build will fail, possibly for seemingly obscure reasons only
becoming (sort of) obvious when one inspects
$target/libphobos/config.log.  I'd call this a regression and it's
certainly a bad user experience.  To make things worse, there's no
--disable-language option, so to avoid this one needs to configure with
an explicit list of languages excluding d, which is going to break (or
miss a possibly working language) the next time one is added to GCC (gm2
is imminent).

I argue that this can be avoided by checking (in toplevel configure)
that a trivial D program can be compiled and linked and excluding d from
the list if languages if not (or aborting the configure run if
absolutely need be).  Much less headache for users, I'd say...

> To pick a similar example, is this a bug?  Or can it be explained away with
> documentation?
> ---
> checking for long long... yes
> checking size of long long... configure: error: in `/work/gcc/build/gcc':
> configure: error: cannot compute sizeof (long long)
> See `config.log' for more details
> make[1]: *** [Makefile:4511: configure-gcc] Error 1
> make[1]: Leaving directory '/work/gcc/build'
> make: *** [Makefile:985: all] Error 2
> ---
> (config.log)
> configure:6450: checking size of long long
> configure:6455: g++ -o conftest -g     conftest.cpp  >&5
> /usr/bin/ld: cannot find -lstdc++
> collect2: error: ld returned 1 exit status
> configure:6455: $? = 1
> configure: program exited with status 1
> ---

But how do you get to such a configuration to begin with?  You're
certainly taking some special steps to have g++, but no libstc++.  This
is contrary to the D situation where that config emerges without doing
anything special.  Similarly for Ada where you either have both gnat and
libgnat or neither.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #7 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Created attachment 52018
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52018&action=edit
configure check compiler driver understands D

How does this patch look?

Because the module name is not "object", it both tests that:
1) The CC driver knows about the D language
2) Compiler proper implicitly tries to import object.d, which would fail if
libphobos was disabled for reasons.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #8 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
(In reply to Iain Buclaw from comment #7)
> Created attachment 52018 [details]
> configure check compiler driver understands D
> 
> How does this patch look?
> 
> Because the module name is not "object", it both tests that:
> 1) The CC driver knows about the D language
Though perhaps I should just use GDC driver to compile though, otherwise it
would break this use-case.

https://gcc.gnu.org/pipermail/gcc-patches/2021-December/585885.html

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain Buclaw <ibuclaw@gcc.gnu.org>:

https://gcc.gnu.org/g:7c6ae994fb587c19ca14aebe18dbc9aca83be609

commit r12-6091-g7c6ae994fb587c19ca14aebe18dbc9aca83be609
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Thu Dec 16 23:56:16 2021 +0100

    config: Add check whether D compiler works (PR103528)

    As well as checking for the existence of a GDC compiler, also validate
    that it has also been built with libphobos, otherwise warn or fail with
    the message that GDC is required to build d.

    config/ChangeLog:

            PR d/103528
            * acx.m4 (ACX_PROG_GDC): Add check whether D compiler works.

    ChangeLog:

            * configure: Regenerate.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed?

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #11 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
> Fixed?

Not completely.  I'd argue we should do two things:

* Document that older GCC versions need to be built with
  --enable-libphobos (SPARC or /bin/as).

* Enable the Solaris libphobos build on SPARC and with /bin/as.  There's
  no reason left to keep those configurations disabled.  I have patches
  for both.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #12 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #11 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot
> Uni-Bielefeld.DE> ---
>> --- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
>> Fixed?
[...]
>   no reason left to keep those configurations disabled.  I have patches
>   for both.

Configure patch now posted:
https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591520.html

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:1375e2b62332351a8f9c928421cd1ea8b53c5127

commit r12-7610-g1375e2b62332351a8f9c928421cd1ea8b53c5127
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Fri Mar 11 09:37:44 2022 +0100

    libphobos: Enable on Solaris/SPARC or with /bin/as [PR 103528]

    libphobos is currently only enabled on Solaris/x86 with gas.  As
    discovered when gdc was switched to the dmd frontend, this initially
    broke bootstrap for the other Solaris configurations.

    However, it's now well possible to enable it both for Solaris/x86 with
    as and Solaris/SPARC (both as and gas) since the original problems (x86
    as linelength limit, among others) are long gone.

    The following patch does just that.

    Tested on i386-pc-solaris2.11 and sparc-sun-solaris2.11 (both as and
    gas) with gdc 9.3.0 (x86) resp. 9.4.0 (sparc, configured with
    --enable-libphobos) as bootstrap compilers.

    2021-12-01  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            libphobos:
            PR d/103528
            * configure.ac <x86_64-*-solaris2.* | i?86-*-solaris2.*>: Remove
            gas requirement.
            * configure: Regenerate.
            * configure.tgt (sparc*-*-solaris2.11*): Mark supported.

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #14 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
"ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org> writes:
> --- Comment #11 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot
> Uni-Bielefeld.DE> ---
>> --- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
>> Fixed?
>
> Not completely.  I'd argue we should do two things:
>
> * Document that older GCC versions need to be built with
>   --enable-libphobos (SPARC or /bin/as).

Doc patch now posted, too: 

https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591844.html

[Bug d/103528] [12 regression] d21 doesn't build on Solaris

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:4e4f550a5bc588a76452941cb3fb887a20f8a6cc

commit r12-8298-g4e4f550a5bc588a76452941cb3fb887a20f8a6cc
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Thu Apr 28 10:27:32 2022 +0200

    doc: Document Solaris D bootstrap requirements [PR 103528]

    This patch documents the Solaris-specific D bootstrap requirements.

    Tested by building and inspecting gccinstall.{pdf,info}.


    2022-03-16  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            gcc:
            PR d/103528
            * doc/install.texi (Tools/packages necessary for building GCC)
            (GDC): Document libphobos requirement.
            (Host/target specific installation notes for GCC, *-*-solaris2*):
            Document libphobos and GDC specifics.

[Bug d/103528] [12/13 regression] d21 doesn't build on Solaris

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.0                        |12.2

--- Comment #16 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 12.1 is being released, retargeting bugs to GCC 12.2.

[Bug d/103528] [12/13 regression] d21 doesn't build on Solaris

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

--- Comment #18 from Richard Biener <rguenth at gcc dot gnu.org> ---
What's the status of this bug now?

[Bug d/103528] [12/13/14 regression] d21 doesn't build on Solaris

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103528

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #19 from Rainer Orth <ro at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #18)
> What's the status of this bug now?

AFAICS everything is in place now, both code and documentation changes.