[Bug middle-end/103642] New: [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N])

[Bug middle-end/103642] New: [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N])

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103642

            Bug ID: 103642
           Summary: [12 Regression] ICE in lower_omp_target:
                    omp-low.c:12977 (fold_convert_loc) for omp target
                    map(from: t.s->a[:N])
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code, openmp
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: cltang at gcc dot gnu.org, jakub at gcc dot gnu.org
  Target Milestone: ---

Compiling
https://github.com/clang-ykt/omptests/blob/master/t-partial-struct/test.cpp
fails now as follows:

during GIMPLE pass: omplower
t-partial-struct/test.cpp: In function ‘int main()’:
t-partial-struct/test.cpp:232:13: internal compiler error: in fold_convert_loc,
at fold-const.c:2450
  232 |     #pragma omp target map(from: t.s->a[:N])
      |             ^~~
0x7d313f fold_convert_loc(unsigned int, tree_node*, tree_node*)
        ../../repos/gcc/gcc/fold-const.c:2450
0x11218d4 lower_omp_target
        ../../repos/gcc/gcc/omp-low.c:12977
0x11218d4 lower_omp_1
        ../../repos/gcc/gcc/omp-low.c:14223
0x11218d4 lower_omp
        ../../repos/gcc/gcc/omp-low.c:14362


Until recently, it failed with:
  t-partial-struct/test.cpp:232:37: error: expected ')' before '->' token
which means this is a regression.


Reduced testcase - compile with "gcc / g++ -fopenmp":

typedef struct {
  int *a;
} SSS;
typedef struct {
  SSS *s;
} TTT;
main() {
  TTT t;
#pragma omp target map(t.s->a[9])
  ;
}

[Bug middle-end/103642] [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) since r12-5835-g0ab29cf0bb68960c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103642

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12 Regression] ICE in      |[12 Regression] ICE in
                   |lower_omp_target:           |lower_omp_target:
                   |omp-low.c:12977             |omp-low.c:12977
                   |(fold_convert_loc) for omp  |(fold_convert_loc) for omp
                   |target map(from:            |target map(from:
                   |t.s->a[:N])                 |t.s->a[:N]) since
                   |                            |r12-5835-g0ab29cf0bb68960c
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2021-12-10
                 CC|                            |marxin at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-5835-g0ab29cf0bb68960c.

[Bug middle-end/103642] [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) since r12-5835-g0ab29cf0bb68960c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103642

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug middle-end/103642] [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) since r12-5835-g0ab29cf0bb68960c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103642

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug middle-end/103642] [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) since r12-5835-g0ab29cf0bb68960c

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103642

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Crossref - Chung-Lin's patch (approved):
https://gcc.gnu.org/pipermail/gcc-patches/2022-January/588720.html

[Bug middle-end/103642] [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) since r12-5835-g0ab29cf0bb68960c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103642

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Chung-Lin Tang <cltang@gcc.gnu.org>:

https://gcc.gnu.org/g:1c91b014923f418e0aab789c5cf57facf04bf266

commit r12-6890-g1c91b014923f418e0aab789c5cf57facf04bf266
Author: Chung-Lin Tang <cltang@codesourcery.com>
Date:   Thu Jan 27 18:33:00 2022 +0800

    Fix omp-low ICE for indirect references based off component access
[PR103642]

    This issue was triggered after the patch extending syntax for component
access
    in map clauses in commit 0ab29cf0bb68960c1f87405f14b4fb2109254e2f.

    In gimplify_scan_omp_clauses, the case for handling indirect accesses
(which
    creates firstprivate ptr and zero-length array section map for such decls)
was
    erroneously went into for non-pointer cases (here being the base struct
decl),
    so added the
    appropriate checks there.

    Added new testcase is a compile only test for the ICE. The original
omptests
    t-partial-struct test actually should not execute correctly, because for
    map(t.s->a[:N]), map(t.s[:1]) is not implicitly mapped, thus the entire
    offloaded access does not work as is (fixing that omptests test is out of
    scope here).

    2022-01-27  Chung-Lin Tang  <cltang@codesourcery.com>

            PR middle-end/103642

    gcc/ChangeLog:

            * gimplify.cc (gimplify_scan_omp_clauses): Do not do indir_p
handling
            for non-pointer or non-reference-to-pointer cases.

    gcc/testsuite/ChangeLog:

            * c-c++-common/gomp/pr103642.c: New test.

[Bug middle-end/103642] [12 Regression] ICE in lower_omp_target: omp-low.c:12977 (fold_convert_loc) for omp target map(from: t.s->a[:N]) since r12-5835-g0ab29cf0bb68960c

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103642

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
In my understanding, this patch is now FIXED.

In particular, also the longer testcases works.
Thanks ChungLin for fixing it!